-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce max_replication_write_lag to 10Mb #1793
Conversation
We probably should also update it in the console, I found several references there: |
@knizhnik , I added small fix to tests and pushed to trigger tests again. |
6fb5f3a
to
6345b24
Compare
Rebased |
@knizhnik , any next steps planned for this? |
we've increased the lag to 15 MBs, maybe we can close this PR? |
We have not changed default value. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, if I understand correctly, we currently use values <100MB effectively everywhere, and only this default is exceptionally large. If that understanding is correct, I think this is OK to merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these values now the same that we use in production?
This new default is off by 5MB from our production settings for PG15:
|
9364e3c
to
0452866
Compare
No description provided.