Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce max_replication_write_lag to 10Mb #1793

Merged
merged 2 commits into from
Nov 23, 2022
Merged

Reduce max_replication_write_lag to 10Mb #1793

merged 2 commits into from
Nov 23, 2022

Conversation

knizhnik
Copy link
Contributor

No description provided.

@lubennikovaav
Copy link
Contributor

@knizhnik , I added small fix to tests and pushed to trigger tests again.

@hlinnaka
Copy link
Contributor

hlinnaka commented Jul 5, 2022

Rebased

@stepashka
Copy link
Member

@knizhnik , any next steps planned for this?
have we merged this?
was it causing any troubles?

@stepashka
Copy link
Member

we've increased the lag to 15 MBs, maybe we can close this PR?

@knizhnik
Copy link
Contributor Author

we've increased the lag to 15 MBs, maybe we can close this PR?

We have not changed default value.
There is really IMHO stupid situation that some our default settings, particularly wal_log_hints and max_replication write_lag, which are different from what are actually used for tests and in staging/production.

@knizhnik knizhnik closed this Nov 22, 2022
@knizhnik knizhnik reopened this Nov 22, 2022
Copy link
Contributor

@MMeent MMeent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, if I understand correctly, we currently use values <100MB effectively everywhere, and only this default is exceptionally large. If that understanding is correct, I think this is OK to merge.

Copy link
Contributor

@hlinnaka hlinnaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these values now the same that we use in production?

@MMeent
Copy link
Contributor

MMeent commented Nov 22, 2022

This new default is off by 5MB from our production settings for PG15:

$ SHOW max_replication_lag;
 max_replication_write_lag 
---------------------------
 15MB

@knizhnik knizhnik requested review from a team as code owners November 22, 2022 15:34
@knizhnik knizhnik merged commit 1af0874 into main Nov 23, 2022
@knizhnik knizhnik deleted the backpressure_delay branch November 23, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants