Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for replacement of the failed safekeeper #1179

Merged
merged 6 commits into from
Jan 27, 2022
Merged

Add test for replacement of the failed safekeeper #1179

merged 6 commits into from
Jan 27, 2022

Conversation

petuhovskiy
Copy link
Member

@petuhovskiy petuhovskiy commented Jan 25, 2022 •
edited
Loading

Add a test with the following script:

  1. compute is working ok with sk1,sk2,sk3
  2. sk1 is killed due a "failure", but compute continue to work with sk2,sk3
  3. sk4 is created for replacement and compute is restarted with sk2,sk3,sk4
  4. sk2 is killed and now compute should work fine with sk3,sk4, to check that sk4 is working

Fixes #893
Fixes #808 ?

See neondatabase/postgres#123 for fixes on the walproposer side

@petuhovskiy petuhovskiy requested review from arssher and removed request for arssher January 25, 2022 15:22
@petuhovskiy
Copy link
Member Author

It seems that this test passes because of some funny coincidences, I'll try to make it fail now.

@petuhovskiy
Don't call adjust_for_wal_acceptors after pg create
e7af9bc 
Now zenith_cli handles wal_acceptors config internally, and if we
will append wal_acceptors to postgresql.conf in python tests, then
it will contain duplicate wal_acceptors config.
@petuhovskiy
Add test to replace failed safekeeper
bbcddc5
@petuhovskiy
Fix python codestyle
73cfd7f
@petuhovskiy
Restart safekeepers in test_replace_safekeeper
5ba7894
@petuhovskiy
Update vendor/postgres
1ca285d
@petuhovskiy petuhovskiy force-pushed the test-replace-safekeeper branch from 89c1717 to 1ca285d Compare January 27, 2022 10:14
@petuhovskiy petuhovskiy marked this pull request as ready for review January 27, 2022 10:22
@petuhovskiy petuhovskiy requested a review from arssher January 27, 2022 14:22
@petuhovskiy petuhovskiy merged commit cedde55 into main Jan 27, 2022
@petuhovskiy petuhovskiy deleted the test-replace-safekeeper branch January 27, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arssher arssher Awaiting requested review from arssher

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@petuhovskiy