Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write to console instead of file, to leverage GHA native logs #37

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

aldenquimby
Copy link
Contributor

@aldenquimby aldenquimby commented Nov 7, 2023

Background

  • I recently started using this action and noticed the run logs don't have meaningful output:
image
  • To see the logs, I need to navigate back to a run summary, download an artifact, unzip, and view:
image

image

  • Afterwards, I need to delete the zip + txt file from my local machine

Proposal

  • This PR proposes inlining the logs instead, so they are immediately useful and searchable within the native GHA log UI:
image
  • Added benefit of removing a dependency on the upload-artifacts action

Copy link
Member

@duskpoet duskpoet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you have a chance to test this out? I have a feeling that bash command output is not copied to GHA output

@aldenquimby
Copy link
Contributor Author

aldenquimby commented Nov 7, 2023

@duskpoet yes I tested this by switching my project to use aldenquimby/create-branch-action@alden-test-output and it worked. See the screenshot at the bottom of the PR description for what it looks like

@duskpoet
Copy link
Member

duskpoet commented Nov 8, 2023

Thanks!

@duskpoet duskpoet merged commit 863b797 into neondatabase:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants