Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the list of remaining breaking changes, this PR implements the one and only remaining case where the Neon API uses a
u32
but should use ausize
:JsArray::new()
.I did an audit of all other occurrences of
u32
in the codebase and all the remaining instances are fine:JsArray::len()
-- Node-API exposes this asu32
ref
/unref
-- Node-API exposes this asu32
u32
Finalize
implementation foru32
-- this is just predefined on a bunch of Rust primitive types