Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scope abstraction that was only necessary for the legacy backend #888

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

kjvalencik
Copy link
Member

  • Active check is no longer necessary since changing execute_scoped and compute_scoped to take &mut self
  • Remove scope metadata since compute_scoped and execute_scoped are the only places scope needs to be tracked
  • Apply simplifications everywhere from the first two changes

In order to use Drop for scopes--which is a little cleaner and protects us from panic leaks--env is stored both in the scope and on the Context. This additional pointer is a small cost and overall much smaller than the removed ScopeMetadata.

@kjvalencik kjvalencik requested a review from dherman April 15, 2022 15:36
Copy link
Collaborator

@dherman dherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kjvalencik kjvalencik merged commit 41efb77 into main Apr 29, 2022
@kjvalencik kjvalencik deleted the kv/scope-cleanup branch April 29, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants