Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Option<T: Finalize> implement Finalize #680

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

jrose-signal
Copy link
Contributor

@jrose-signal jrose-signal commented Feb 9, 2021

Ran into this recently, though admittedly I was using Finalize outside of its primary purpose of JsBox. I considered whether Result should implement Finalize as well, but decided that was a bit trickier.

Are there any tests I should add here?

@kjvalencik
Copy link
Member

kjvalencik commented Feb 10, 2021

Thanks for the contribution! This code is pretty trivial and doesn't require a test. I agree that Result would be trickier because either type (or both) might be Finalize and we would end up with overlapping impl trying to handle them.

We would only be able to provide the most strict where both <T: Finalize, E: Finalize> and that doesn't seem common enough to be useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants