n-api: use napi_get_all_property_names
#601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8de0bf4 to
e961c15
Compare
e961c15 to
5eca8b8
Compare
kjvalencik
reviewed
Sep 22, 2020
| } | ||
| fixed_len += 1; | ||
| } | ||
| *out = property_names.assume_init(); |
There was a problem hiding this comment.
I just noticed this. I'll write a ticket for some clean-up in neon. This should probably also be using a MaybeUninit on the calling side or be returning an Option instead fo a boolean.
There was a problem hiding this comment.
Yeah, this is a common pattern throughout neon-runtime. Since these runtime functions don't need to be FFI-safe anymore with N-API, we can safely use things like Options for this stuff, but it probably needs to wait until the NAN backend is removed.
kjvalencik
approved these changes
Sep 22, 2020
|
@goto-bus-stop Great clean-up! Much nicer! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the
JsObject::get_own_property_namesactually correct.napi_get_all_property_nameswas added in N-API version 6, so it raises our support floor to Node.js v10.20.0.