Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows compilation issues #156

Merged
merged 2 commits into from
Dec 25, 2016
Merged

Windows compilation issues #156

merged 2 commits into from
Dec 25, 2016

Conversation

dherman
Copy link
Collaborator

@dherman dherman commented Dec 24, 2016

(Separated out from #122.)

maxbrunsfeld and others added 2 commits December 23, 2016 22:55
@maxbrunsfeld
Use statically-dispatched destructor call to work around MSVC bug
f6643b2
Disable WholeProgramOptimization along with LinkTimeCodeGeneration
14e7f7d 
...because they were preventing `neon_sys` functions from being included
into the `neon_sys` object file on Windows.

Signed-off-by: Max Brunsfeld <maxbrunsfeld@github.com>
@dherman dherman requested a review from jedireza December 24, 2016 08:25
jedireza
jedireza approved these changes Dec 24, 2016
View reviewed changes
Copy link
Contributor

@jedireza jedireza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ :shipit:

@dherman dherman merged commit 304d9f9 into master Dec 25, 2016
@amilajack amilajack deleted the windows-compilation-issues branch September 19, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedireza jedireza jedireza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dherman @jedireza @maxbrunsfeld