Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.21] Implement common networking with config tasks #1483

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

Shadows-of-Fire
Copy link
Contributor

This PR changes the common networking approach to use configuration tasks instead of simply sending the packets during connection init. This aligns with the expectations set by fabric in FabricMC/fabric#3244.

Fixes #1473

@Shadows-of-Fire Shadows-of-Fire added bug A bug or error networking Related to networking 1.21.1 Targeted at Minecraft 1.21.1 labels Aug 24, 2024
@Shadows-of-Fire Shadows-of-Fire self-assigned this Aug 24, 2024
@neoforged-pr-publishing
Copy link

neoforged-pr-publishing bot commented Aug 24, 2024

  • Publish PR to GitHub Packages

Last commit published: e807fde261fb619719e4c6326469e59e4c841c71.

PR Publishing

The artifacts published by this PR:

Repository Declaration

In order to use the artifacts published by the PR, add the following repository to your buildscript:

repositories {
    maven {
        name 'Maven for PR #1483' // https://github.com/neoforged/NeoForge/pull/1483
        url 'https://prmaven.neoforged.net/NeoForge/pr1483'
        content {
            includeModule('net.neoforged', 'neoforge')
            includeModule('net.neoforged', 'testframework')
        }
    }
}

MDK installation

In order to setup a MDK using the latest PR version, run the following commands in a terminal.
The script works on both *nix and Windows as long as you have the JDK bin folder on the path.
The script will clone the MDK in a folder named NeoForge-pr1483.
On Powershell you will need to remove the -L flag from the curl invocation.

mkdir NeoForge-pr1483
cd NeoForge-pr1483
curl -L https://prmaven.neoforged.net/NeoForge/pr1483/net/neoforged/neoforge/21.1.25-pr-1483-creg-config-tasks/mdk-pr1483.zip -o mdk.zip
jar xf mdk.zip
rm mdk.zip || del mdk.zip

To test a production environment, you can download the installer from here.

@sciwhiz12 sciwhiz12 self-requested a review August 25, 2024 03:11
Copy link
Member

@sciwhiz12 sciwhiz12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it works. Connecting to a Fabric (w/ Fabric API) server (incl. the server mentioned in the original issue) works, as well as connecting to a NeoForge server without the changes in this PR. Also tested with a Fabric (w/ Fabric API) client connecting to a server with this PR, and that too works.

@sciwhiz12 sciwhiz12 merged commit 659d33f into neoforged:1.21.x Aug 31, 2024
7 checks passed
@neoforged-releases
Copy link

🚀 This PR has been released as NeoForge version 21.1.34.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.21.1 Targeted at Minecraft 1.21.1 bug A bug or error networking Related to networking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to connect to Fabric server
2 participants