Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bangumi catalog #790

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

j1g5awi
Copy link

@j1g5awi j1g5awi commented Dec 7, 2024

  1. match "ISBN", old "isbn" is wrong
  2. fix localized_title order
  3. set name_cn's language to zh-cn even it is eng

@alphatownsman
Copy link
Member

Thanks for the PR. Can you add a test case?

also I haven't seen https://chii.in before, can you post a link to explain this is an official url for bangumi?

@j1g5awi
Copy link
Author

j1g5awi commented Dec 9, 2024

also I haven't seen https://chii.in before, can you post a link to explain this is an official url for bangumi?

actually chii.in is registered in 2008, early than bgm.tv

can https://github.com/bangumi/frontend/blob/0b709bdd523a25e7ecb77de2ade90fcd87295a92/packages/utils/bbcode/convert.ts#L5 prove its official domain?

and tests is coming...

@alphatownsman
Copy link
Member

Yes. Thank you!

@alphatownsman alphatownsman merged commit 3209ca8 into neodb-social:main Dec 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

2 participants