Add empty line between Characters in lookup #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello! I'm unaware of what consequences this small change might have for other parts of the program, or other programs that could be expecting the input in a certain format. I added a line to `dump_results` to add some space between each character found - this way I think it also matches the rest of the information's formatting. So now, when running `python3 -m jamdict.tools lookup 言語学` I get ``` ======================================== Found entries ======================================== Entry: 1264430 | Kj: 言語学 | Kn: げんごがく -------------------- 1. linguistics ((noun (common) (futsuumeishi))) ======================================== Found characters ======================================== Char: 言 | Strokes: 7 -------------------- Readings: yan2, eon, 언, Ngôn, Ngân, ゲン, ゴン, い.う, こと Meanings: say, word Char: 語 | Strokes: 14 -------------------- Readings: yu3, yu4, eo, 어, Ngữ, Ngứ, ゴ, かた.る, かた.らう Meanings: word, speech, language Char: 学 | Strokes: 8 -------------------- Readings: xue2, hag, 학, Học, ガク, まな.ぶ Meanings: study, learning, science No name was found. ``` Instead of getting: ``` ======================================== Found entries ======================================== Entry: 1264430 | Kj: 言語学 | Kn: げんごがく -------------------- 1. linguistics ((noun (common) (futsuumeishi))) ======================================== Found characters ======================================== Char: 言 | Strokes: 7 -------------------- Readings: yan2, eon, 언, Ngôn, Ngân, ゲン, ゴン, い.う, こと Meanings: say, word Char: 語 | Strokes: 14 -------------------- Readings: yu3, yu4, eo, 어, Ngữ, Ngứ, ゴ, かた.る, かた.らう Meanings: word, speech, language Char: 学 | Strokes: 8 -------------------- Readings: xue2, hag, 학, Học, ガク, まな.ぶ Meanings: study, learning, science No name was found. ``` Again, this could have more implications that I know, but I made the small change for myself and thought of submitting this pull request. Thank you, ~romes
|
hi @alt-romes thank you for this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I'm unaware of what consequences this small change might have for other parts of the program, or other programs that could be expecting the input in a certain format.
I added a line to
dump_resultsto add some space between each character found - this way I think it also matches the rest of the information's formatting.So now, when running
python3 -m jamdict.tools lookup 言語学I getInstead of getting:
Again, this could have more implications that I know, but I made the small change for myself and thought of submitting this pull request.
Thank you,
~romes