-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ExecuteQueryWithTransactionConfig
option for ExecuteQuery
#553
Add ExecuteQueryWithTransactionConfig
option for ExecuteQuery
#553
Conversation
ExecuteQueryWithTransactionConfig
option for ExecuteQuery
ExecuteQueryWithTransactionConfig
option for ExecuteQuery
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
consider adding unit tests
neo4j/driver_with_context.go
Outdated
// ExecuteQueryConfiguration holds all the possible configuration settings for DriverWithContext.ExecuteQuery | ||
type ExecuteQueryConfiguration struct { | ||
Routing RoutingControl | ||
ImpersonatedUser string | ||
Database string | ||
BookmarkManager BookmarkManager | ||
BoltLogger log.BoltLogger | ||
Configurers []func(*TransactionConfig) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call it something more self-explanatory like TransactionConfigurers
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ExecuteQuery
docs could use an update. Especially the section following
The equivalent functionality of ExecuteQuery can be replicated with pre-existing APIs as follows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs for WithTxTimeout
and WithTxMetadata
list examples for each of the APIs they can be used with. Consider adding ExecuteQueryWithTransactionConfig
there.
A new
ExecuteQueryConfigurationOption
has been added (ExecuteQueryWithTransactionConfig
) to specify transaction config like metadata and transaction timeout withExecuteQuery
.