Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new notification categories SECURITY and TOPOLOGY #537

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add new notification categories SECURITY and TOPOLOGY #537

merged 1 commit into from
Oct 11, 2023

Conversation

StephenCathcart
Copy link
Contributor

Added Topology and Security notification categories to align with the new categories as of the 5.14 server.

@StephenCathcart
Copy link
Contributor Author

Add new notification categories SECURITY and TOPOLOGY to drivers [Go]

thelonelyvulpes
thelonelyvulpes approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@thelonelyvulpes thelonelyvulpes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple, and clean.

bigmontz
bigmontz approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@bigmontz bigmontz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

(Is there not tests for this?)

robsdedude
robsdedude approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@robsdedude robsdedude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔕

@StephenCathcart
Copy link
Contributor Author

🥇

(Is there not tests for this?)

I thought this too but the other notifications don't seem to have any, maybe I should look at adding more unit tests around this 👍

@StephenCathcart StephenCathcart merged commit ede36d4 into neo4j:5.0 Oct 11, 2023
@StephenCathcart StephenCathcart deleted the feature/add-new-notifications branch October 11, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelonelyvulpes thelonelyvulpes thelonelyvulpes approved these changes

@robsdedude robsdedude robsdedude approved these changes

@bigmontz bigmontz bigmontz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@StephenCathcart @bigmontz @robsdedude @thelonelyvulpes