Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Disconnect Where Args Not Implementing Aliases #907

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

tbwiss
Copy link
Contributor

@tbwiss tbwiss commented Feb 2, 2022

Description

Using DBpropertyName instead of fieldName for node where clause.

Issue

#894

@darrellwarde
Copy link
Contributor

Get 894.test.js renamed to 894.test.ts and this PR looks pretty good to me! 😄

@angrykoala angrykoala marked this pull request as ready for review February 2, 2022 15:54
@angrykoala
Copy link
Member

angrykoala commented Feb 2, 2022

@tbwiss I made a bit of cleanup and took care of the .js -> .ts change, please review my last commit to this PR and if you are happy with it feel free to merge 🚀

Copy link
Contributor Author

@tbwiss tbwiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clean up @angrykoala!
Good to go from my side.

@angrykoala angrykoala merged commit 746eee9 into neo4j:master Feb 2, 2022
@darrellwarde darrellwarde linked an issue Feb 2, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disconnect Where Args Not Implementing Aliases
3 participants