Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing Relationship Description #820

Merged
merged 3 commits into from
Jan 19, 2022

Conversation

dmoree
Copy link
Contributor

@dmoree dmoree commented Jan 19, 2022

Description

This PR addresses #764 by adding the description field.

Issue

Checklist

The following requirements should have been met (depending on the changes in the branch):

@dmoree
Copy link
Contributor Author

dmoree commented Jan 19, 2022

@darrellwarde There should probably be a decision on whether to add a description to the generated {field}Connection or even the {field}Aggregate field and what that would look like. I would be happy to include that in this PR if desired.

@darrellwarde darrellwarde linked an issue Jan 19, 2022 that may be closed by this pull request
@darrellwarde
Copy link
Contributor

@darrellwarde There should probably be a decision on whether to add a description to the generated {field}Connection or even the {field}Aggregate field and what that would look like. I would be happy to include that in this PR if desired.

Tricky one that! What would it look like? If description is not null, output (using your test) "Actors in Movie (Relay Connection field)" and "Actors in Movie (Aggregate values)"?

I think we should just address the bug at hand - the purpose of the other two fields can be inferred from the description on the "main" relationship field in my opinion.

Thanks for this work.

Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@darrellwarde darrellwarde merged commit 3133db9 into neo4j:dev Jan 19, 2022
@dmoree dmoree deleted the fix/relationship-description branch January 19, 2022 18:37
@renovate renovate bot mentioned this pull request Jan 22, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Augmented schema is missing description for relationship fields
2 participants