Aggregation filters #5879
Merged
Aggregation filters #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8fcfe20 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
2533b0f to
c11f69d
Compare
MacondoExpress
approved these changes
Dec 12, 2024
| case "equals": | ||
| case "eq": | ||
| return "EQUAL"; | ||
| case "lessThan": // TODO: remove long syntax once tests have been updated |
There was a problem hiding this comment.
This has already been removed!
| @@ -608,6 +613,29 @@ export class FilterFactory { | |||
| throw new Error(`Invalid operator ${key}`); | |||
| } | |||
| } | |||
| private parseGenericOperatorForAggregation(key: string): AggregationLogicalOperator { | |||
There was a problem hiding this comment.
I believe we can reuse parseGenericOperator!
There was a problem hiding this comment.
These are not the same filters, even if they have the same name, the typings are defined to use one or the other, and I rather keep the nice typings
| @@ -919,4 +987,27 @@ export class FilterFactory { | |||
| } | |||
| return targetPoint; | |||
| } | |||
|
|
|||
| private parsedGenericAggregationOperator(key: string): AggregationOperator { | |||
There was a problem hiding this comment.
Suggested change
| private parsedGenericAggregationOperator(key: string): AggregationOperator { | |
| private parseGenericAggregationOperator(key: string): AggregationOperator { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add generic filters for aggregations:
{ posts(where: { likesAggregate: { node: { rating: { average: { eq: 3.2 } } } } }) { title } }