Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/null points #565

Merged
merged 2 commits into from
Nov 5, 2021
Merged

Fix/null points #565

merged 2 commits into from
Nov 5, 2021

Conversation

danstarns
Copy link
Contributor

@danstarns danstarns commented Nov 5, 2021 •
edited
Loading

Description

Fixes issue where is a Point is null and throws error on GraphQL layer. Uses runFirstColumn with a CASE statement to ensure we only project point elements that are not NULL.

Issue

#560

oskarhane
oskarhane approved these changes Nov 5, 2021
View reviewed changes
Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Even if we don't want to use more APOC, I think in cases like this we don't have much of an option.

@danstarns danstarns merged commit fdf5d7a into neo4j:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskarhane oskarhane oskarhane approved these changes

@angrykoala angrykoala Awaiting requested review from angrykoala

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danstarns @oskarhane