Added OpenID Json Web Key Sets for verification via the @auth directive #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
oskarhane
reviewed
Nov 5, 2021
There was a problem hiding this comment.
Thank you for this PR @dvanmali, really appreciate it.
Looks good in general, just a small comment.
Also, could you come up with a way to test this (that it takes the code path when the config value is set) so we don't introduce regressions in the future?
The value is already set so there is no need of a default value ""
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to OpenID configuration, verification of JWTs should be validated against the authentication server's JWKS to ensure that the server signed it. Instead of interpreting the JWT via a secret or PEM file (which if maliciously stolen, could rewrite JWTs), we verify via the signature represented by the token's kid at the endpoint
https://YOUR_DOMAIN/.well-known/jwks.json.These changes are currently non-breaking changes.
Issue
#252
Passing a decoded token only partially solves this verification issue. We'd rather perform verification via the GraphQL @auth directive so checks occur at each request and are done without secrets.
Checklist
The following requirements should have been met (depending on the changes in the branch):