Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue 488 handle union where on connections #540

Merged
merged 10 commits into from
Oct 26, 2021
Merged

Fix issue 488 handle union where on connections #540

merged 10 commits into from
Oct 26, 2021

Conversation

danstarns
Copy link
Contributor

@danstarns danstarns commented Oct 17, 2021 •
edited
Loading

Description

Fixes issue where using where on a connection that is a union.

Issue

#488

@danstarns danstarns added the fix label Oct 17, 2021
@darrellwarde darrellwarde linked an issue Oct 19, 2021 that may be closed by this pull request
node argument to createConnectionWhereAndParams is undefined when querying on Unions #488
Closed
angrykoala
angrykoala requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@angrykoala angrykoala left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍 , just some minor comments

packages/graphql/src/translate/create-where-and-params.ts Outdated Show resolved Hide resolved
packages/graphql/src/translate/create-where-and-params.ts Outdated Show resolved Hide resolved
packages/graphql/src/translate/create-where-and-params.ts Outdated Show resolved Hide resolved
packages/graphql/tests/integration/issues/488.int.test.ts Outdated Show resolved Hide resolved
@danstarns danstarns requested a review from angrykoala October 25, 2021 18:50
@danstarns danstarns merged commit c8e4a1c into neo4j:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angrykoala angrykoala angrykoala approved these changes

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node argument to createConnectionWhereAndParams is undefined when querying on Unions
2 participants
@danstarns @angrykoala