Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minimum database version to 4.1.5 #378

Merged

Conversation

darrellwarde
Copy link
Contributor

@darrellwarde darrellwarde commented Aug 2, 2021

Description

Following reports that our changes to connect operations no longer work on 4.1.0, I iterated through versions to find the minimum which we now support - 4.1.5 is where all tests start passing.

Also fixes version checking, now uses semver package for comparison. For non-semantic APOC version, strips off the trailing number.

Also, now throws all compatibility issues in one error, rather than throwing as soon as it hits each.

Worthwhile adding an integration test pipeline for 4.1.5 exactly (rather than 4.1.x as current, I'm assuming 4.1.9) so we can easily tell if and when we break compatibility?

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

Copy link
Member

@oskarhane oskarhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to add an additional compat test for minimun supported version 👍
Can you create a card for it (or add the test job in the pipe)?

@darrellwarde
Copy link
Contributor Author

Sounds good to add an additional compat test for minimun supported version 👍
Can you create a card for it (or add the test job in the pipe)?

I sure can, will add to the pipeline now! 🙂

@darrellwarde
Copy link
Contributor Author

Made some code changes since approvals - would appreciate a re-review before merging @danstarns @oskarhane. 🙂

@darrellwarde
Copy link
Contributor Author

Merging because test failure is on Aura Professional build which isn't actually hooked up to the pipeline yet - need to work around a few unexpected failures there.

@darrellwarde darrellwarde merged commit adfa6e7 into neo4j:2.0.0 Aug 3, 2021
@darrellwarde darrellwarde deleted the change-database-dependency-to-4.1.5 branch May 9, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants