Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential fix for the problem serializing Int/Float values #240

Merged
merged 2 commits into from
Jun 18, 2021

Conversation

darrellwarde
Copy link
Contributor

@darrellwarde darrellwarde commented Jun 8, 2021

Description

#230 fixed for input, and wanted to wait for user feedback before fixing for output. Bugs indeed still present there, so this fix addresses serializing values in a different way.

Issue

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • TCK tests have been updated
  • Integration tests have been updated
  • Example applications have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed

@darrellwarde darrellwarde requested a review from danstarns as a code owner June 8, 2021 15:03
@darrellwarde
Copy link
Contributor Author

A nice simple fix - awaiting feedback to see whether this has fixed issues or not, as still unable to reproduce ourselves.

@darrellwarde
Copy link
Contributor Author

Sadly, as much as this doesn't break anything, it also doesn't fix our issue - this needs more investigation and work. 🙁

@darrellwarde
Copy link
Contributor Author

Let's merge this anyway as I feel it gets us closer to the final solution to this problem, and also contains an auxiliary bug fix which will address #266.

@darrellwarde darrellwarde linked an issue Jun 18, 2021 that may be closed by this pull request
@darrellwarde darrellwarde merged commit 86bfaf5 into neo4j:master Jun 18, 2021
@darrellwarde darrellwarde deleted the bugfix/int-serialization branch May 9, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cypher convert Int as Float
2 participants