Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix temporal type issues with neo4j-driver@4.3.0 #226

Merged
merged 2 commits into from
May 28, 2021

Conversation

oskarhane
Copy link
Member

@oskarhane oskarhane commented May 27, 2021

The latest release of neo4j-driver has changes file paths and the code in this library relied on a file being in a certain place.
This PR removes that and imports from the root path only.

I'm not 100% sure how we're going to test this with all versions of the driver we allow as peer dependencies yet. It's late and something for tomorrow.

  • Integration tests have been updated

+ bump drivers in package tests
Copy link
Contributor

@darrellwarde darrellwarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, LGTM! 🌟

@oskarhane oskarhane merged commit 1591800 into neo4j:master May 28, 2021
@oskarhane oskarhane deleted the fix-driver-datetime-issue branch May 28, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants