Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use neo4j int for limit and skip #209

Closed
wants to merge 1 commit into from

Conversation

reaperdtme
Copy link

Description

Use neo4j's int for limit and skip

Issue

#208

@darrellwarde
Copy link
Contributor

Hey @aspectgfg, thanks for the contribution. As much as I wish this bug were this simple, it is not. As you can see from our Cypher TCK test for pagination, this is already happening for the most part: https://github.com/neo4j/graphql/blob/master/packages/graphql/tests/tck/tck-test-files/cypher/pagination.md

For some reason, however, our custom scalar which is meant to do this for us is sometimes not working in certain scenarios. We do have this on our to-do list for this dev phase, where we are going to take a more holistic look at this (not just skip and limit), so going to close this based on that fact.

For future pull requests, can you please leave the checklist from the template in? It is meant to help both contributors and reviewers monitor state of a pull request. For instance, you need to sign the Neo4j CLA to contribute to this repo: https://neo4j.com/developer/cla/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants