Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write details to transaction metadata instead of useragent #1143

Merged

Conversation

darrellwarde
Copy link
Contributor

Description

Overriding the driver useragent is not a reliable way of getting the details of the Neo4j GraphQL Library into the Neo4j query log. This instead writes those details to the transaction metadata, which are also available to view in logs.

@tbwiss tbwiss self-requested a review March 16, 2022 16:22
Copy link
Contributor

@tbwiss tbwiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat solution!
Tried it locally and checked the query.log file, the metadata is present.

@angrykoala angrykoala merged commit f75c04e into neo4j:master Mar 17, 2022
@darrellwarde darrellwarde deleted the fix/useragent-not-being-overridden branch May 9, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants