Make sure aliases are checked against connectOrCreate where input #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbwiss
reviewed
Mar 16, 2022
Co-authored-by: Thomas Wiss <thomas.wiss@hotmail.com>
|
I don't know what to do about the non-null assertions here - TypeScript not detecting that the variable is not undefined despite having an explicit check. |
angrykoala
previously approved these changes
Mar 17, 2022
packages/graphql/src/translate/cypher-builder/build-merge-statement.ts
Outdated
Show resolved
Hide resolved
angrykoala
reviewed
Mar 17, 2022
angrykoala
approved these changes
Mar 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When generating the initial
MERGEin aconnectOrCreate, the inputwhereobject was not being checked against aliases for database properties. This adds that check.Issue
Closes #1131.
Checklist
The following requirements should have been met (depending on the changes in the branch):