Fix 1073 connectOrCreate schema #1110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darrellwarde
previously approved these changes
Mar 10, 2022
packages/graphql/tests/integration/connect-or-create/connect-or-create-id.int.test.ts
Outdated
Show resolved
Hide resolved
|
Tests updated, this pr does not cover newly found bug #1124 |
darrellwarde
approved these changes
Mar 15, 2022
There was a problem hiding this comment.
Broadly speaking, this looks good! I have a suggestion - should we make the onCreate input field non-nullable? That way, despite the where, we will always force our users to specify what the fields should be on creation, which will make it easier to change the implementation under the hood.
|
🤔 @darrellwarde onCreate is already required, or am I missing something? |
I might be losing my mind. 🙃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #1073 by properly marking the required fields in the connectOrCreate -> onCreateInput
Closes #1073