Reduce Common Usage between APOC Extended and APOC Core #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ba3df7e to
9f4e08f
Compare
b7ad46d to
ca74218
Compare
JoelBergstrand
approved these changes
Jan 8, 2025
Comment on lines
19
to
21
| package apoc.util; | ||
|
|
||
| public class CoreUtil {} |
Comment on lines
+344
to
+354
| public static boolean isFile(String fileName) { | ||
| return from(fileName) == SupportedProtocols.file; | ||
| } | ||
|
|
||
| public static SupportedProtocols from(URL url) { | ||
| return FileUtils.of(url.getProtocol()); | ||
| } | ||
|
|
||
| public static SupportedProtocols from(String source) { | ||
| try { | ||
| final URL url = new URL(source); | ||
| return from(url); | ||
| } catch (MalformedURLException e) { | ||
| if (!e.getMessage().contains("no protocol")) { | ||
| try { | ||
| // in case new URL(source) throw e.g. unknown protocol: hdfs, because of missing jar, | ||
| // we retrieve the related enum and throw the associated MissingDependencyException(..) | ||
| // otherwise we return unknown protocol: yyyyy | ||
| return SupportedProtocols.valueOf(new URI(source).getScheme()); | ||
| } catch (Exception ignored) { | ||
| } | ||
|
|
||
| // in case a Windows user write an url like `C:/User/...` | ||
| if (e.getMessage().contains("unknown protocol") && Util.isWindows()) { | ||
| throw new RuntimeException(e.getMessage() | ||
| + "\n Please note that for Windows absolute paths they have to be explicit by prepending `file:` or supplied without the drive, " | ||
| + "\n e.g. `file:C:/my/path/file` or `/my/path/file`, instead of `C:/my/path/file`"); | ||
| } | ||
| throw new RuntimeException(e); | ||
| } | ||
| return SupportedProtocols.file; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
Is this new or moved from somewhere else?
There was a problem hiding this comment.
This is from somewhere else, APOC config needed it in common still, so instead of not moving an entire file, I kept this one behind iirc
ca74218 to
0def4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.