Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroy standard #182

Merged
merged 23 commits into from
Jan 11, 2025
Merged

Destroy standard #182

merged 23 commits into from
Jan 11, 2025

Conversation

superboyiii
Copy link
Member

No description provided.

@superboyiii
Copy link
Member Author

@ixje Done.

Copy link
Contributor

@ixje ixje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just 2 suggestions on wording.

superboyiii and others added 2 commits September 12, 2024 16:59
Co-authored-by: ixje <git@erikvandenbrink.com>
Co-authored-by: ixje <git@erikvandenbrink.com>
@superboyiii
Copy link
Member Author

@ixje Can I add your name and email on Author?

@ixje
Copy link
Contributor

ixje commented Sep 12, 2024

No need. You authored it, I just gave some feedback.

Copy link
Contributor

@ixje ixje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

shargon and others added 5 commits September 13, 2024 01:11
Co-authored-by: Anna Shaleva <shaleva.ann@gmail.com>
Co-authored-by: Anna Shaleva <shaleva.ann@gmail.com>
Co-authored-by: Anna Shaleva <shaleva.ann@gmail.com>
Co-authored-by: Anna Shaleva <shaleva.ann@gmail.com>
Co-authored-by: Anna Shaleva <shaleva.ann@gmail.com>
@superboyiii
Copy link
Member Author

@AnnaShaleva All done.

shargon
shargon previously approved these changes Sep 27, 2024
Jim8y
Jim8y previously approved these changes Sep 27, 2024
@superboyiii
Copy link
Member Author

@roman-khimov Done

Jim8y and others added 3 commits December 4, 2024 19:42
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Co-authored-by: Christopher Schuchardt <cschuchardt88@gmail.com>
Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have any more comments/suggestions, the proposal itself LGTM, let's update the status to Accepted and wait for the rest of conversations to be resolved.

@superboyiii
Copy link
Member Author

@superboyiii
Copy link
Member Author

All done. @roman-khimov @cschuchardt88

@roman-khimov roman-khimov merged commit 005a759 into neo-project:master Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants