-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Classes for PublicKey and Signature #990
Conversation
Codecov Report
@@ Coverage Diff @@
## master #990 +/- ##
=========================================
+ Coverage 53.77% 53.8% +0.03%
=========================================
Files 194 196 +2
Lines 13251 13290 +39
=========================================
+ Hits 7126 7151 +25
- Misses 6125 6139 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where are these classes being used? Shouldn't we have some tests too?
Still under discussiin @lock9 |
Is ok to me |
Can we close this PR? I think it is a big project to completely replace all public keys and signatures. |
Ok, the idea remains, for the future. I think it's very important for readability. |
Fix withdraw.png
Closes #989