-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super speed multisg unit test #915
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shargon, you are reverting the parallel creation of the wallets, right?
You found that a simple scrypt can be much faster, yes?
But why not process both in parallel?
because now is automatic |
Codecov Report
@@ Coverage Diff @@
## master #915 +/- ##
=======================================
Coverage 45.16% 45.16%
=======================================
Files 178 178
Lines 12609 12609
=======================================
Hits 5695 5695
Misses 6914 6914 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good trick
* Speed up * Remove async
This is the best improve, from 6' to less than one second, for this kind of test, we don't need to test scrypt encryption so is better to test with the lowest values
My concern is that currently, travis spend a lot of time in unit testing