Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super speed multisg unit test #915

Merged
merged 3 commits into from
Jul 15, 2019

Conversation

shargon
Copy link
Member

@shargon shargon commented Jul 12, 2019

This is the best improve, from 6' to less than one second, for this kind of test, we don't need to test scrypt encryption so is better to test with the lowest values

My concern is that currently, travis spend a lot of time in unit testing

@shargon shargon requested a review from erikzhang July 12, 2019 07:56
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shargon, you are reverting the parallel creation of the wallets, right?
You found that a simple scrypt can be much faster, yes?

But why not process both in parallel?

@shargon
Copy link
Member Author

shargon commented Jul 14, 2019

because now is automatic

@codecov-io
Copy link

Codecov Report

Merging #915 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #915   +/-   ##
=======================================
  Coverage   45.16%   45.16%           
=======================================
  Files         178      178           
  Lines       12609    12609           
=======================================
  Hits         5695     5695           
  Misses       6914     6914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d662e4a...5fcd855. Read the comment docs.

Copy link
Contributor

@lock9 lock9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good trick

@shargon shargon merged commit ad6200b into neo-project:master Jul 15, 2019
@shargon shargon deleted the super-speed-multisg branch July 15, 2019 21:01
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants