Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up mempool reverify on policy change #892

Merged
merged 8 commits into from
Jul 11, 2019

Conversation

vncoelho
Copy link
Member

@vncoelho vncoelho commented Jul 5, 2019

@igormcoelho @shargon @erikzhang
Check if this is nice :D

@erikzhang, once more, congratulate you because the NEO 3 code is becoming much more simple and clear! Great job you have been doing, master.

@codecov-io
Copy link

codecov-io commented Jul 6, 2019

Codecov Report

Merging #892 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #892      +/-   ##
==========================================
- Coverage   45.16%   45.16%   -0.01%     
==========================================
  Files         178      178              
  Lines       12608    12609       +1     
==========================================
  Hits         5695     5695              
- Misses       6913     6914       +1
Impacted Files Coverage Δ
neo/Ledger/MemoryPool.cs 77.94% <0%> (-0.3%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e36bf8...fca24ee. Read the comment docs.

@vncoelho vncoelho merged commit 59b5257 into master Jul 11, 2019
@vncoelho vncoelho deleted the speed-up-mempool-reverify-on-policy-change branch July 11, 2019 13:04
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
Tommo-L pushed a commit to Tommo-L/neo that referenced this pull request Jun 22, 2020
* Speed up mempool reverify on policy change

* Caching newFeePerByte before loop

* Reverting fee per byte check when PolicyChange

* optimize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants