DeriveKey Scrypt unit test #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #886 +/- ##
=======================================
Coverage 45.04% 45.04%
=======================================
Files 178 178
Lines 12603 12603
=======================================
Hits 5677 5677
Misses 6926 6926Continue to review full report at Codecov.
|
erikzhang
reviewed
Jul 5, 2019
|
This does not change the results, right? |
|
Yes, this change the results of the output hash |
|
I think it is not compatible with scrypt. In RFC 7914, it is fixed at |
|
Because scrypt add extra security layer (and this method is used only with scrypt), maybe is not needed. If you want i can remove all changes except the unit test |
|
Yes, please. |
erikzhang
reviewed
Jul 5, 2019
vncoelho
reviewed
Jul 5, 2019
lock9
approved these changes
Jul 8, 2019
Thacryba
pushed a commit
to simplitech/neo
that referenced
this pull request
Feb 17, 2020
* 调整样式，兼容 IE10+ * 修复 Edge 兼容性问题
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
* Strengthen PBKDF2 * Update SCrypt.cs * Scrypt DeriveKey ut * Deterministic behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of iterations is set to only to 1, last NIST recommendation (from 2016) is 10.000 (https://pages.nist.gov/800-63-3/sp800-63b.html#sec5).