Fix AssetDescriptor #882
Merged
Fix AssetDescriptor #882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Master, Shargon, fast as a bolt. |
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 44.72% 44.93% +0.21%
==========================================
Files 177 177
Lines 12577 12577
==========================================
+ Hits 5625 5652 +27
+ Misses 6952 6925 -27
Continue to review full report at Codecov.
|
igormcoelho
reviewed
Jul 2, 2019
neo/Wallets/AssetDescriptor.cs
Outdated
| @@ -19,7 +19,7 @@ public AssetDescriptor(UInt160 asset_id) | |||
| sb.EmitAppCall(asset_id, "name"); | |||
| script = sb.ToArray(); | |||
| } | |||
| ApplicationEngine engine = ApplicationEngine.Run(script); | |||
| ApplicationEngine engine = ApplicationEngine.Run(script, extraGAS: 10_000_000); | |||
There was a problem hiding this comment.
We can adjust it to a better one
There was a problem hiding this comment.
This seems arbitrary. Would setting test mode be a better approach?
There was a problem hiding this comment.
name() may contain an infinite loop, and testMode can cause the client to fail to jump out of an infinite loop.
erikzhang
reviewed
Jul 3, 2019
erikzhang
approved these changes
Jul 3, 2019
Tommo-L
pushed a commit
to Tommo-L/neo
that referenced
this pull request
Jun 22, 2020
* Fix * Better with fixed gas * Remove testnet * Fix Better with fixed gas Remove testnet * UT Asset Description * Reduce limit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #881