UT for Version/Verack messages #853

lock9 · 2019-06-24T06:02:02Z

Unit tests for RemoteNode and ProtocolHandler actors (Version and Verack only)

shargon · 2019-06-24T07:15:39Z

Could you review your indentation?
I fixed it according to visual studio default indentation here https://github.com/simplitech/neo/pull/1/files

vncoelho

Nice job, Rickk Hearth @lock9.

It will be crucial to have this part with better UTs. Great initiative.
I will check the code again asap.

THANKS MAN!

lock9 · 2019-06-24T18:46:25Z

@shargon merged! Thanks!

neo/Network/P2P/RemoteNode.cs

neo.UnitTests/UT_RemoteNode.cs

Removing shutdown; Initializing testblockchain during class setup (only once)

…into ut-version-verack # Conflicts: # neo.UnitTests/UT_RemoteNode.cs

codecov-io · 2019-06-24T22:07:42Z

Codecov Report

Merging #853 into master will increase coverage by 1.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #853      +/-   ##
==========================================
+ Coverage   43.56%   44.72%   +1.16%     
==========================================
  Files         177      177              
  Lines       12577    12577              
==========================================
+ Hits         5479     5625     +146     
+ Misses       7098     6952     -146

Impacted Files	Coverage Δ
neo/Network/P2P/Peer.cs	`9.09% <0%> (+1.13%)`	⬆️
neo/Network/P2P/LocalNode.cs	`22.01% <0%> (+3.66%)`	⬆️
neo/IO/Actors/PriorityMessageQueue.cs	`93.1% <0%> (+6.89%)`	⬆️
neo/Network/P2P/ProtocolHandler.cs	`17.67% <0%> (+10.69%)`	⬆️
neo/Network/P2P/Payloads/VersionPayload.cs	`81.08% <0%> (+29.72%)`	⬆️
neo/Network/P2P/RemoteNode.cs	`40.88% <0%> (+37.1%)`	⬆️
neo/Network/P2P/Connection.cs	`42.22% <0%> (+42.22%)`	⬆️
neo/Network/P2P/Capabilities/FullNodeCapability.cs	`58.33% <0%> (+58.33%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd28e4a...af1efe5. Read the comment docs.

neo/UIntBase.cs

vncoelho · 2019-06-24T22:38:23Z

Great job, Ricardo! +1,13% that are hard to achieve :)

igormcoelho · 2019-06-24T23:21:39Z

Ricardo, congratulations! Fine job! Can we remove your last commit? So we merge first #857

Then we format it again here after merge. It will create a much simpler merge.

[EDIT:] don't worry about the other PR... this one will probably go first.

neo/Network/P2P/RemoteNode.cs

neo/Network/P2P/ProtocolHandler.cs

neo.UnitTests/UT_ProtocolHandler.cs

neo.UnitTests/UT_RemoteNode.cs

igormcoelho · 2019-06-29T13:18:20Z

Ricardo, I'll try to pass basic formatting at once, to simplify your PR changes here. Easier to evaluate.

[EDIT:]

Ok! Dropped from 20 files to just 5 ;) Time to review!

igormcoelho · 2019-06-29T22:58:02Z

Ricardo, I think it's fine for me now, ready for approval. Please confirm if changes are good, I removed many auxiliar classes you did... but I think it's enough for testing. Otherwise we can undo my commits and try again.

vncoelho

Good PR since the beginning, but even better now.

neo/Network/P2P/RemoteNode.cs

igormcoelho · 2019-07-01T02:42:04Z

@erikzhang please take a look at last commit... it tries to move Actor creation to NeoSystem class, through CreateActor method. This makes easier to check mailboxes, and also to create test actors when necessary (just need to mock NeoSystem class). I think NeoSystem should be available on Peer class, so it's inherited on LocalNode.. just need to find a good way to do that. Some actors may still be created outside NeoSystem, but the most important ones are there.

erikzhang · 2019-07-01T08:08:10Z

Please revert the last commit...We should not create all actors in NeoSystem. It is not used to do this.

This reverts commit 3ad56f7.

igormcoelho · 2019-07-01T13:41:03Z

@erikzhang @lock9 I managed to make it work without the parameter passing, and avoiding all hard tricks... Solution was to instantiate ProtocolHandler using system.ActorSystem instead of Context, as this allows a slightly better integration, and objects are already available. Changes are very small now. It was good to listen to Erik, because code is working fine without any special changes... we need to understand these TestActors better Ricardo.

igormcoelho

Only few changes now, nothing big affected. Fine for me.

neo/Network/P2P/RemoteNode.cs

neo.UnitTests/UT_ProtocolHandler.cs

neo.UnitTests/UT_RemoteNode.cs

vncoelho · 2019-07-03T00:34:50Z

Erik master yoda.

* UT for Version/Verack messages * Indentation * Indentation * Update ProtocolHandler.cs * Fixing ClassInit; Removing shutdown; Initializing testblockchain during class setup (only once) * Running formatter * Eriks suggestion * fix typo * removed ProtocolFactory * remove TestProtocolFactory * simplify * CreateActor * Revert "CreateActor" This reverts commit 3ad56f7. * removed parameter from RemoteNode * fix * removed unused parameters * format

lock9 and others added 3 commits June 24, 2019 02:52

UT for Version/Verack messages

6e51178

Indentation

dc7b4d5

Indentation

d1d4935

vncoelho reviewed Jun 24, 2019

View reviewed changes

vncoelho and others added 2 commits June 24, 2019 11:14

Merge branch 'master' into ut-version-verack

a208f3c

Merge pull request #1 from shargon/indentation

b51893b

THANKS MAN!

vncoelho reviewed Jun 24, 2019

View reviewed changes

neo/Network/P2P/RemoteNode.cs Outdated Show resolved Hide resolved

neo.UnitTests/UT_RemoteNode.cs Outdated Show resolved Hide resolved

shargon and others added 4 commits June 24, 2019 20:59

Update ProtocolHandler.cs

99fa0fa

Fixing ClassInit;

dd092f9

Removing shutdown; Initializing testblockchain during class setup (only once)

Merge branch 'ut-version-verack' of https://github.com/simplitech/neo …

a4b479e

…into ut-version-verack # Conflicts: # neo.UnitTests/UT_RemoteNode.cs

Running formatter

fb3b76a

vncoelho reviewed Jun 24, 2019

View reviewed changes

neo/UIntBase.cs Outdated Show resolved Hide resolved

igormcoelho reviewed Jun 25, 2019

View reviewed changes

neo/Network/P2P/RemoteNode.cs Outdated Show resolved Hide resolved

erikzhang reviewed Jun 25, 2019

View reviewed changes

neo/Network/P2P/ProtocolHandler.cs Outdated Show resolved Hide resolved

erikzhang reviewed Jun 26, 2019

View reviewed changes

neo.UnitTests/UT_ProtocolHandler.cs Outdated Show resolved Hide resolved

igormcoelho and others added 2 commits June 26, 2019 19:45

Eriks suggestion

1f800ec

Merge branch 'master' into ut-version-verack

fd136fb

erikzhang reviewed Jun 28, 2019

View reviewed changes

neo.UnitTests/UT_RemoteNode.cs Outdated Show resolved Hide resolved

Merge branch 'master' into ut-version-verack

600c0ee

igormcoelho added 4 commits June 29, 2019 18:17

Merge branch 'master' into ut-version-verack

41f255a

fix typo

ad1832c

removed ProtocolFactory

25b804c

remove TestProtocolFactory

55085db

simplify

ac4ba6b

igormcoelho dismissed their stale review via ac4ba6b June 29, 2019 23:20

igormcoelho previously approved these changes Jun 29, 2019

View reviewed changes

shargon previously approved these changes Jun 30, 2019

View reviewed changes

vncoelho previously approved these changes Jun 30, 2019

View reviewed changes

erikzhang reviewed Jun 30, 2019

View reviewed changes

neo/Network/P2P/RemoteNode.cs Outdated Show resolved Hide resolved

CreateActor

3ad56f7

igormcoelho dismissed stale reviews from vncoelho, shargon, and themself via 3ad56f7 July 1, 2019 02:39

igormcoelho added 2 commits July 1, 2019 10:26

Revert "CreateActor"

3f3e38b

This reverts commit 3ad56f7.

removed parameter from RemoteNode

1799197

igormcoelho previously approved these changes Jul 1, 2019

View reviewed changes

erikzhang reviewed Jul 1, 2019

View reviewed changes

neo/Network/P2P/RemoteNode.cs Outdated Show resolved Hide resolved

fix

7d6f2cd

erikzhang dismissed igormcoelho’s stale review via 7d6f2cd July 1, 2019 20:16

erikzhang reviewed Jul 1, 2019

View reviewed changes

neo.UnitTests/UT_ProtocolHandler.cs Outdated Show resolved Hide resolved

neo.UnitTests/UT_ProtocolHandler.cs Outdated Show resolved Hide resolved

neo.UnitTests/UT_RemoteNode.cs Outdated Show resolved Hide resolved

neo.UnitTests/UT_RemoteNode.cs Show resolved Hide resolved

removed unused parameters

215c99b

shargon previously approved these changes Jul 2, 2019

View reviewed changes

format

af1efe5

erikzhang dismissed shargon’s stale review via af1efe5 July 3, 2019 06:55

erikzhang approved these changes Jul 3, 2019

View reviewed changes

shargon approved these changes Jul 3, 2019

View reviewed changes

shargon merged commit 0dc5fa0 into neo-project:master Jul 3, 2019

Jim8y mentioned this pull request May 25, 2022

node: ? ?? New Release - a Docker image, plz neo-project/neo-node#824

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

UT for Version/Verack messages #853

UT for Version/Verack messages #853

lock9 commented Jun 24, 2019

shargon commented Jun 24, 2019

vncoelho left a comment

lock9 commented Jun 24, 2019

codecov-io commented Jun 24, 2019 •

edited

Loading

vncoelho commented Jun 24, 2019

igormcoelho commented Jun 24, 2019 •

edited

Loading

igormcoelho commented Jun 29, 2019 •

edited

Loading

igormcoelho commented Jun 29, 2019

vncoelho left a comment •

edited

Loading

igormcoelho commented Jul 1, 2019 •

edited

Loading

erikzhang commented Jul 1, 2019

igormcoelho commented Jul 1, 2019 •

edited

Loading

igormcoelho left a comment

vncoelho commented Jul 3, 2019

UT for Version/Verack messages #853

UT for Version/Verack messages #853

Conversation

lock9 commented Jun 24, 2019

shargon commented Jun 24, 2019

vncoelho left a comment

Choose a reason for hiding this comment

lock9 commented Jun 24, 2019

codecov-io commented Jun 24, 2019 • edited Loading

Codecov Report

vncoelho commented Jun 24, 2019

igormcoelho commented Jun 24, 2019 • edited Loading

igormcoelho commented Jun 29, 2019 • edited Loading

igormcoelho commented Jun 29, 2019

vncoelho left a comment • edited Loading

Choose a reason for hiding this comment

igormcoelho commented Jul 1, 2019 • edited Loading

erikzhang commented Jul 1, 2019

igormcoelho commented Jul 1, 2019 • edited Loading

igormcoelho left a comment

Choose a reason for hiding this comment

vncoelho commented Jul 3, 2019

codecov-io commented Jun 24, 2019 •

edited

Loading

igormcoelho commented Jun 24, 2019 •

edited

Loading

igormcoelho commented Jun 29, 2019 •

edited

Loading

vncoelho left a comment •

edited

Loading

igormcoelho commented Jul 1, 2019 •

edited

Loading

igormcoelho commented Jul 1, 2019 •

edited

Loading