Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Send Idle message to actors when they are idle. #502

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Send Idle message to actors when they are idle. #502

merged 2 commits into from
Dec 5, 2018

Conversation

erikzhang
Copy link
Member

No description provided.

@erikzhang erikzhang requested a review from jsolman December 5, 2018 06:53
@erikzhang erikzhang mentioned this pull request Dec 5, 2018
Merged
jsolman
jsolman previously approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

jsolman
jsolman reviewed Dec 5, 2018
View reviewed changes
Copy link
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question; suppose there is only one high priority message in the queue and no low priority messages, after the high priority one is processed it is idle, but idle message won’t be added. Is this the intent?

@erikzhang
Copy link
Member Author

One question; suppose there is only one high priority message in the queue and no low priority messages, after the high priority one is processed it is idle, but idle message won’t be added. Is this the intent?

fixed

jsolman
jsolman approved these changes Dec 5, 2018
View reviewed changes
Copy link
Contributor

@jsolman jsolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@erikzhang erikzhang merged commit 7c8bf1f into master Dec 5, 2018
@erikzhang erikzhang deleted the feature/idle_message branch December 5, 2018 07:29
rodoufu pushed a commit to rodoufu/neo that referenced this pull request Mar 5, 2019
@erikzhang @rodoufu
Send Idle message to actors when they are idle. (neo-project#502)
e6d6f31
Thacryba pushed a commit to simplitech/neo that referenced this pull request Feb 17, 2020
@Celia18305
Update setup.md (neo-project#502)
82ed475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsolman jsolman jsolman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erikzhang @jsolman