Maybe the first requested block hash is missing #494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If yes, let's also fix that for the headers request, @erikzhang. |
jsolman
reviewed
Nov 30, 2018
| @@ -156,7 +156,8 @@ private void OnGetBlocksMessageReceived(GetBlocksPayload payload) | |||
| BlockState state = Blockchain.Singleton.Store.GetBlocks().TryGet(hash); | |||
| if (state == null) return; | |||
| List<UInt256> hashes = new List<UInt256>(); | |||
| for (uint i = 1; i <= InvPayload.MaxHashesCount; i++) | |||
| hashes.Add(hash); | |||
There was a problem hiding this comment.
I think the code that requests always gives the hash before the one that it actually expects to get back first
There was a problem hiding this comment.
Looks like you are right again, Jeff.
It starts with UInt256 hash = Blockchain.Singleton.CurrentBlockHash;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@erikzhang, @jsolman,
I am not sure, but I think that the first requested block hash was missing.