Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Linux File Access #3769

Merged
merged 11 commits into from
Feb 18, 2025
Merged

[Fix] Linux File Access #3769

merged 11 commits into from
Feb 18, 2025

Conversation

cschuchardt88
Copy link
Member

Description

Add some stuff to hope once and for all fix the linux workflows

Type of change

  • Optimization (the change is only an optimization)
  • Style (the change is only a code style for better maintenance or standard purpose)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cschuchardt88 cschuchardt88 self-assigned this Feb 15, 2025
@Jim8y Jim8y requested a review from superboyiii February 16, 2025 01:13
shargon
shargon reviewed Feb 16, 2025
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, wait for @superboyiii

superboyiii
superboyiii approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@superboyiii superboyiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested PASS

@shargon shargon merged commit fdd852e into neo-project:master Feb 18, 2025
6 checks passed
@shargon shargon deleted the fix/workflows-vm branch February 18, 2025 09:39
AnnaShaleva pushed a commit to AnnaShaleva/neo that referenced this pull request Feb 19, 2025
@cschuchardt88 @Jim8y
@shargon @AnnaShaleva
[Fix] Linux File Access (neo-project#3769)
cb41f92 
* Add some stuff to hope once and for all fix the linux workflows

* update workflow

* update nuget.yml

* Change dig to detailed, log too big

* Fix targets

* revert main.yml

* Update .github/workflows/main.yml

* disable BuildInParallel

---------

Co-authored-by: Jimmy <jinghui@wayne.edu>
Co-authored-by: Shargon <shargon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@superboyiii superboyiii superboyiii approved these changes

Assignees

@cschuchardt88 cschuchardt88

Labels
GitHub Workflow Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cschuchardt88 @shargon @superboyiii @Jim8y