Fix InvalidOperationException #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnnaShaleva it seems that is not called inside the VM, could you also checked please? |
AnnaShaleva
reviewed
Oct 29, 2024
AnnaShaleva
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Oct 29, 2024
Inspired by neo-project/neo#3558, although this PR fixes different implementation of stackitem serializatior that is used outside of VM. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Jim8y
approved these changes
Oct 29, 2024
nan01ab
reviewed
Oct 29, 2024
| json["value"] = new JArray(((IList<KeyValuePair<ContractParameter, ContractParameter>>)parameter.Value).Select(p => | ||
| { | ||
| JObject item = new(); | ||
| item["key"] = ToJson(p.Key, context); | ||
| item["value"] = ToJson(p.Value, context); | ||
| return item; | ||
| })); | ||
| context.Remove(parameter); | ||
| if (!context.Remove(parameter)) throw new InvalidOperationException("Circular reference."); |
There was a problem hiding this comment.
Why is this if statement needed?
There was a problem hiding this comment.
It should not happen, but always is a good practice checks the methods returns
nan01ab
approved these changes
Oct 30, 2024
AnnaShaleva
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Close #3553
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: