Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error when vc_redist is missing #3293

Merged
merged 3 commits into from
Jun 7, 2024
Merged

Fix error when vc_redist is missing #3293

merged 3 commits into from
Jun 7, 2024

Conversation

chenzhitong
Copy link
Member

close #3199

before:
image

after:
image

Jim8y
Jim8y previously approved these changes Jun 6, 2024
View reviewed changes
@Jim8y
Copy link
Contributor

Jim8y commented Jun 6, 2024

I would say,,,, neo-cli is damaged, please download it from xxxxxx, instead of just handling a specific dll.

@cschuchardt88
Copy link
Member

cschuchardt88 commented Jun 6, 2024 •
edited
Loading

I would compile the newest libleveldb yours is only 257kb and new one is 259kb maybe that is the problem. Also keep in mind, there is different versions of the dll for C++.

@shargon shargon merged commit 38cc0e9 into neo-project:master Jun 7, 2024
7 checks passed
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 7, 2024
@Jim8y
Merge branch 'fix-negative-counter' of github.com:Jim8y/neo into fix-…
093d857 
…negative-counter

* 'fix-negative-counter' of github.com:Jim8y/neo:
  Fix error when vc_redist is missing (neo-project#3293)
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 8, 2024
@Jim8y
Merge branch 'fix-3300' of github.com:Jim8y/neo into fix-3300
2e742cc 
* 'fix-3300' of github.com:Jim8y/neo:
  Fix error when vc_redist is missing (neo-project#3293)
Jim8y added a commit to Jim8y/neo that referenced this pull request Jun 8, 2024
@Jim8y
Merge branch 'master' into isolate-plugins
13e9b94 
* master:
  Fix error when vc_redist is missing (neo-project#3293)
  Fixed up `main.yml` (neo-project#3292)
  [Neo Core Style] Rename parameters, update comments, fix code style (neo-project#3294)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@cschuchardt88 cschuchardt88 cschuchardt88 approved these changes

@Jim8y Jim8y Jim8y approved these changes

@AnnaShaleva AnnaShaleva AnnaShaleva approved these changes

Assignees
No one assigned
Labels
Ready to Merge Waiting for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The release "neo-cli-win-x64.zip" can't run on Windows Server
5 participants
@chenzhitong @Jim8y @cschuchardt88 @shargon @AnnaShaleva