Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed up main.yml #3292

Merged
merged 41 commits into from
Jun 7, 2024
Merged

Fixed up main.yml #3292

Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
8b64351
Added `BaseOutputPath`
cschuchardt88 Jun 5, 2024
88f521e
Remove binaries
cschuchardt88 Jun 5, 2024
d6e628b
Fixed Build
cschuchardt88 Jun 5, 2024
6b784a2
Changed output directory `github` actions
cschuchardt88 Jun 5, 2024
b095480
Fixed tests
cschuchardt88 Jun 5, 2024
f4972ce
Fixed bug with `output`
cschuchardt88 Jun 5, 2024
ca4ae65
Added `test` soltion file
cschuchardt88 Jun 5, 2024
823f8a6
Remove output for mac and windows
cschuchardt88 Jun 5, 2024
0bfe9e5
Fixed Coveralls
cschuchardt88 Jun 5, 2024
5ba38b1
Fixed Coveralls `path`
cschuchardt88 Jun 5, 2024
1a1335d
Revert "Fixed Coveralls `path`"
cschuchardt88 Jun 5, 2024
6af1f81
Fixed up coverall
cschuchardt88 Jun 5, 2024
0e8c10c
Fixed `mergewith`
cschuchardt88 Jun 5, 2024
ac260b0
Fixed pathing
cschuchardt88 Jun 5, 2024
e51a3a1
fixed `ls` command
cschuchardt88 Jun 5, 2024
d311bef
Fixed all paths for tests
cschuchardt88 Jun 5, 2024
ac8d508
Added new steps and jobs
cschuchardt88 Jun 5, 2024
70ace83
Move a command
cschuchardt88 Jun 5, 2024
aab490f
Added new path for `coverage.cobertura.xml` report
cschuchardt88 Jun 5, 2024
8ea70ae
Changed `Coveralls` report path
cschuchardt88 Jun 5, 2024
fa7bbfa
Fixed pathing for `TestResults`
cschuchardt88 Jun 5, 2024
5cfc2a3
Fixed Report location
cschuchardt88 Jun 5, 2024
57e1150
Fixed Report location
cschuchardt88 Jun 5, 2024
4116b85
Fixed file extensions
cschuchardt88 Jun 5, 2024
2ce14f4
Fixed `MergeWith` path
cschuchardt88 Jun 5, 2024
f395f73
Added list directory
cschuchardt88 Jun 5, 2024
a7f882c
Changed format coverage.lcov
cschuchardt88 Jun 5, 2024
15c57b8
Added all files
cschuchardt88 Jun 5, 2024
d03a9a0
Fixed location
cschuchardt88 Jun 5, 2024
4389801
Fixed path for lcov
cschuchardt88 Jun 5, 2024
e803906
Fixed file extension
cschuchardt88 Jun 5, 2024
a1d6fe4
Added `${{ github.workspace }}/`
cschuchardt88 Jun 5, 2024
0526e8d
Fixed path
cschuchardt88 Jun 5, 2024
4730ab7
sfs
cschuchardt88 Jun 5, 2024
3bcd995
Fixed files argument
cschuchardt88 Jun 5, 2024
9e5468b
Fixed files
cschuchardt88 Jun 5, 2024
2ddcffa
Fixed `Neo.Json.UnitTests` path
cschuchardt88 Jun 5, 2024
f5c0133
Fixed `Neo.Json.UnitTests` test output path
cschuchardt88 Jun 5, 2024
75ad6e3
Update .github/workflows/main.yml
Jim8y Jun 5, 2024
2f1d5b3
Merge branch 'master' into fix/plugins-output
cschuchardt88 Jun 5, 2024
4bae6c5
Merge branch 'master' into fix/plugins-output
shargon Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 45 additions & 26 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,30 @@ on:

env:
DOTNET_VERSION: 8.0.x
COVERALL_COLLECT_OUTPUT: "/p:CollectCoverage=true /p:CoverletOutput='${{ github.workspace }}/TestResults/coverage/'"
COVERALL_MERGE_PATH: "/p:MergeWith='${{ github.workspace }}/TestResults/coverage/coverage.json'"

jobs:

Format:
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/checkout@v4

- name: Setup .NET
uses: actions/setup-dotnet@v4
with:
dotnet-version: ${{ env.DOTNET_VERSION }}

- name: Check Format (*.cs)
run: dotnet format --verify-no-changes --verbosity diagnostic

- name: Build (Neo.CLI)
run: |
dotnet build ./src/Neo.CLI \
--output ./out/Neo.CLI
Comment on lines +24 to +30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a side comment: it might be a good idea to split this job into Format and Build, because Format job itself does not block the Test job. And then Test job may be dependent only on Build job. It's just the way how it works for NeoGo actions, and sometimes it's useful because your code may have a lack of formatting and you'll get your test results anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a required step/job. That is why its linked to tests. Or else @shargon would have to make the build and format job required for PRs.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine, or it can be done in a different PR, if the format is wrong we get the error earlier


Test:
needs: [Format]
timeout-minutes: 15
strategy:
matrix:
Expand All @@ -25,14 +43,6 @@ jobs:
uses: actions/setup-dotnet@v4
with:
dotnet-version: ${{ env.DOTNET_VERSION }}
- name: Check format
if: matrix.os == 'ubuntu-latest'
run: |
dotnet format --verify-no-changes --verbosity diagnostic
- name: Build CLI
if: matrix.os == 'ubuntu-latest'
run: |
dotnet publish ./src/Neo.CLI
- name: Test
if: matrix.os != 'ubuntu-latest'
run: |
Expand All @@ -42,31 +52,40 @@ jobs:
if: matrix.os == 'ubuntu-latest'
run: |
sudo apt-get --assume-yes install libleveldb-dev librocksdb-dev
dotnet test ./tests/Neo.Cryptography.BLS12_381.Tests ${{ env.COVERALL_COLLECT_OUTPUT }}
dotnet test ./tests/Neo.ConsoleService.Tests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}
dotnet test ./tests/Neo.UnitTests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}
dotnet test ./tests/Neo.VM.Tests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}
dotnet test ./tests/Neo.Json.UnitTests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}

dotnet test ./tests/Neo.Cryptography.BLS12_381.Tests --output ./bin/tests/Neo.Cryptography.BLS12_381.Tests
dotnet test ./tests/Neo.ConsoleService.Tests --output ./bin/tests/Neo.ConsoleService.Tests
dotnet test ./tests/Neo.UnitTests --output ./bin/tests/Neo.UnitTests
dotnet test ./tests/Neo.VM.Tests --output ./bin/tests/Neo.VM.Tests
dotnet test ./tests/Neo.Json.UnitTests --output ./bin/tests/Neo.Json.UnitTests

# Plugins
dotnet test ./tests/Neo.Cryptography.MPTTrie.Tests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}
dotnet test ./tests/Neo.Network.RPC.Tests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}
dotnet test ./tests/Neo.Plugins.OracleService.Tests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}
dotnet test ./tests/Neo.Plugins.RpcServer.Tests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }}
dotnet test ./tests/Neo.Plugins.Storage.Tests ${{ env.COVERALL_COLLECT_OUTPUT }} ${{ env.COVERALL_MERGE_PATH }} /p:CoverletOutputFormat='cobertura'
dotnet test ./tests/Neo.Cryptography.MPTTrie.Tests --output ./bin/tests/Neo.Cryptography.MPTTrie.Tests
dotnet test ./tests/Neo.Network.RPC.Tests --output ./bin/tests/Neo.Network.RPC.Tests
dotnet test ./tests/Neo.Plugins.OracleService.Tests --output ./bin/tests/Neo.Plugins.OracleService.Tests
dotnet test ./tests/Neo.Plugins.RpcServer.Tests --output ./bin/tests/Neo.Plugins.RpcServer.Tests
dotnet test ./tests/Neo.Plugins.Storage.Tests --output ./bin/tests/Neo.Plugins.Storage.Tests

- name: Coveralls
if: matrix.os == 'ubuntu-latest'
uses: coverallsapp/github-action@v2.3.0
with:
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
format: cobertura
file: ${{ github.workspace }}/TestResults/coverage/coverage.cobertura.xml
files:
${{ github.workspace }}/tests/Neo.Cryptography.BLS12_381.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.ConsoleService.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.UnitTests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.VM.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.Json.UnitTests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.Cryptography.MPTTrie.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.Network.RPC.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.Plugins.OracleService.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.Plugins.RpcServer.Tests/TestResults/coverage.info
${{ github.workspace }}/tests/Neo.Plugins.Storage.Tests/TestResults/coverage.info

PublishPackage:
if: github.ref == 'refs/heads/master' && startsWith(github.repository, 'neo-project/')
needs: Test
needs: [Test]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down Expand Up @@ -115,7 +134,7 @@ jobs:

Release:
if: github.ref == 'refs/heads/master' && startsWith(github.repository, 'neo-project/')
needs: Test
needs: [Test]
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand Down
1 change: 1 addition & 0 deletions src/Neo.CLI/Neo.CLI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
<Product>Neo.CLI</Product>
<ApplicationIcon>neo.ico</ApplicationIcon>
<Nullable>enable</Nullable>
<BaseOutputPath>$(SolutionDir)/bin/$(AssemblyTitle)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Neo.ConsoleService/Neo.ConsoleService.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>netstandard2.1;net8.0</TargetFrameworks>
<PackageId>Neo.ConsoleService</PackageId>
<Nullable>enable</Nullable>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Neo.Cryptography.BLS12_381/Neo.Cryptography.BLS12_381.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<TargetFrameworks>netstandard2.1;net8.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<PackageId>Neo.Cryptography.BLS12_381</PackageId>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed, what is this packageID need?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this package created here or elsewhere?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I searched quickly here and found that packageId was more related to dependency.

Copy link
Member Author

@cschuchardt88 cschuchardt88 Jun 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its for nuget. The nuget filename and package name of the package.

<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Neo.Extensions/Neo.Extensions.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
<PropertyGroup>
<TargetFrameworks>netstandard2.1;net8.0</TargetFrameworks>
<Nullable>enable</Nullable>
<PackageId>Neo.Extensions</PackageId>
<PackageTags>NEO;Blockchain;Extensions</PackageTags>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/Neo.GUI/Neo.GUI.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
<Product>Neo.GUI</Product>
<ApplicationIcon>neo.ico</ApplicationIcon>
<GenerateResourceWarnOnBinaryFormatterUse>false</GenerateResourceWarnOnBinaryFormatterUse>
<BaseOutputPath>$(SolutionDir)/bin/$(AssemblyTitle)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down Expand Up @@ -62,4 +63,4 @@
<ReferenceSourceTarget></ReferenceSourceTarget>
</ProjectReference>
</ItemGroup>
</Project>
</Project>
2 changes: 2 additions & 0 deletions src/Neo.IO/Neo.IO.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<TargetFrameworks>netstandard2.1;net8.0</TargetFrameworks>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<Nullable>enable</Nullable>
<PackageId>Neo.IO</PackageId>
<PackageTags>NEO;Blockchain;IO</PackageTags>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Neo.Json/Neo.Json.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
<TargetFrameworks>netstandard2.1;net8.0</TargetFrameworks>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<PackageId>Neo.Json</PackageId>
<PackageTags>NEO;JSON</PackageTags>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Neo.VM/Neo.VM.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
<TargetFrameworks>netstandard2.1;net8.0</TargetFrameworks>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<Nullable>enable</Nullable>
<PackageId>Neo.VM</PackageId>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Neo/Neo.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
<PropertyGroup>
<TargetFrameworks>netstandard2.1;net8.0</TargetFrameworks>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<PackageId>Neo</PackageId>
<PackageTags>NEO;AntShares;Blockchain;Smart Contract</PackageTags>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/Plugins/ApplicationLogs/ApplicationLogs.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<PackageId>Neo.Plugins.ApplicationLogs</PackageId>
<RootNamespace>Neo.Plugins</RootNamespace>
<ImplicitUsings>enable</ImplicitUsings>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand All @@ -18,4 +19,4 @@
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
</Project>
</Project>
1 change: 1 addition & 0 deletions src/Plugins/DBFTPlugin/DBFTPlugin.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>net8.0</TargetFrameworks>
<PackageId>Neo.Consensus.DBFT</PackageId>
<RootNamespace>Neo.Consensus</RootNamespace>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/Plugins/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\Neo\Neo.csproj" />
<ProjectReference Include="../../Neo/Neo.csproj" />
</ItemGroup>

</Project>
1 change: 1 addition & 0 deletions src/Plugins/LevelDBStore/LevelDBStore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<PackageId>Neo.Plugins.Storage.LevelDBStore</PackageId>
<RootNamespace>Neo.Plugins.Storage</RootNamespace>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

</Project>
1 change: 1 addition & 0 deletions src/Plugins/MPTTrie/MPTTrie.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<PackageId>Neo.Cryptography.MPT</PackageId>
<RootNamespace>Neo.Cryptography</RootNamespace>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

</Project>
3 changes: 2 additions & 1 deletion src/Plugins/OracleService/OracleService.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<PackageId>Neo.Plugins.OracleService</PackageId>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand All @@ -23,4 +24,4 @@
</None>
</ItemGroup>

</Project>
</Project>
1 change: 1 addition & 0 deletions src/Plugins/RocksDBStore/RocksDBStore.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>net8.0</TargetFrameworks>
<PackageId>Neo.Plugins.Storage.RocksDBStore</PackageId>
<RootNamespace>Neo.Plugins.Storage</RootNamespace>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Plugins/RpcClient/RpcClient.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>net8.0</TargetFrameworks>
<PackageId>Neo.Network.RPC.RpcClient</PackageId>
<RootNamespace>Neo.Network.RPC</RootNamespace>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/Plugins/RpcServer/RpcServer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net8.0</TargetFramework>
<PackageId>Neo.Plugins.RpcServer</PackageId>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
1 change: 1 addition & 0 deletions src/Plugins/SQLiteWallet/SQLiteWallet.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<RootNamespace>Neo.Wallets.SQLite</RootNamespace>
<PackageId>Neo.Wallets.SQLite</PackageId>
<ImplicitUsings>enable</ImplicitUsings>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion src/Plugins/StateService/StateService.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
<TargetFrameworks>net8.0</TargetFrameworks>
<PackageId>Neo.Plugins.StateService</PackageId>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand All @@ -18,4 +19,4 @@
</None>
</ItemGroup>

</Project>
</Project>
1 change: 1 addition & 0 deletions src/Plugins/StorageDumper/StorageDumper.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
<PackageId>Neo.Plugins.StorageDumper</PackageId>
<ImplicitUsings>enable</ImplicitUsings>
<Nullable>enable</Nullable>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand Down
5 changes: 3 additions & 2 deletions src/Plugins/TokensTracker/TokensTracker.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFrameworks>net8.0</TargetFrameworks>
<PackageId>Neo.Plugins.TokensTracker</PackageId>
<BaseOutputPath>$(SolutionDir)/bin/$(PackageId)</BaseOutputPath>
</PropertyGroup>

<ItemGroup>
Expand All @@ -15,4 +16,4 @@
</None>
</ItemGroup>

</Project>
</Project>
3 changes: 3 additions & 0 deletions tests/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
<IsPackable>false</IsPackable>
<IsTestProject>true</IsTestProject>
<WarningLevel>0</WarningLevel>
<CollectCoverage>true</CollectCoverage>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this good? Because this is generic to any OS

Copy link
Member Author

@cschuchardt88 cschuchardt88 Jun 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this enables for all tests. I don't know what you mean by generic to any OS. Does it work on all... yes.

<CoverletOutput>TestResults/</CoverletOutput>
<CoverletOutputFormat>lcov</CoverletOutputFormat>
</PropertyGroup>

<ItemGroup>
Expand Down