-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TraverseIterator count #3261
Conversation
Thanks to https://discord.com/channels/382937847893590016/382938783563382784/1242729779753648178 for discovering the bug |
Merged without coverage because it's a bug |
Could not wait 24-48-72 hours? |
Are you running master branch for a mainnet application? @shargon |
@superboyiii require this change and it's a bug, we need to apply this patch asap |
Pal, my bad, this one is a bug fix, need to update the node right away. |
Also #3263 |
We all agreed that 12 hours is good enough for a wait on a merge. I think merging for bug fixes 12 hours is good enough. All other PRs should be merged on a Friday or Monday. Because with all the other merging going on can have bugs in them as well. This way we can push bug fixes |
…gins * 'latest-plugins' of github.com:Jim8y/neo: (21 commits) fix: custom plugins won't shown by command `plugins` (neo-project#3269) COVERALL: Improve maintenance and readbility of some variables (neo-project#3248) Update nuget (neo-project#3262) [**Part-2**] Neo module/master fixes (neo-project#3244) Fix `dotnet pack` error (neo-project#3266) Fix and Update devcontainer.json to use Dockerfile (neo-project#3259) Add optimization to template (neo-project#3247) Optimize plugin's models (neo-project#3246) fix CancelTransaction !signers.Any() (neo-project#3263) COVERALL: fix broken by changing report from lcov to cobertura (neo-project#3252) fix TraverseIterator count (neo-project#3261) Native: include DeprecatedIn hardfork into usedHardforks (neo-project#3245) [**Part-1**] `neo-module/master` (neo-project#3232) Make `ApplicationEngine.LoadContext` protection level `public` (neo-project#3243) improve parse method in neo-cli (neo-project#3204) Fix neo-project#3239 (neo-project#3242) Neo.CLI: enable hardforks for NeoFS mainnet (neo-project#3240) v3.7.4 (neo-project#3237) fix hardfork issues (neo-project#3234) Update src/Neo.CLI/CLI/MainService.Plugins.cs ... # Conflicts: # src/Neo.CLI/CLI/MainService.Plugins.cs
* fix patch from: neo-project/neo#3261 and neo-project/neo#3299 * add neo-project/neo#3282 * add neo-project/neo#3263 * v3.7.5 hotfix * readme
Description
It seems we should limit the count of iterator items <= settings.MaxIteratorResultItems, instead of
>
Type of change
How Has This Been Tested?
No test has been carried out.
Checklist: