Revert "Removed asp.net core"

[shargon]

Reverts #3065
Close neo-project/neo-modules#862

[vncoelho]

I will approve in a minute, I am just rebuilding my setup to ensure I did not made mistake when testing the error.

[cschuchardt88]

Just wait on this

[cschuchardt88]

Ill be adding to neo-cli instead, that will fix it. No rushed need for revert. If no release if due to out come this minute. Lets fix the problem 1st.

There isnt enough information. given for revert

[vncoelho]

The fact is that without neo-project/neo-modules@e9e7a07 the module does not build.
But even with it is produces error when running, missing some dependencies. (it just occurs on nodes with RpcServer)

I forced added rpcserver published dlls into client (everything built with same framework and same environment), and still some errors.

[vncoelho]

With this broken all others PR can not be tested properly.

[cschuchardt88]

Plus in this introduces a new problem

[cschuchardt88]

The fact is that without neo-project/neo-modules@e9e7a07 the module does not build. But even with it is produces error when running, missing some dependencies. (it just occurs on nodes with RpcServer)

I forced added rpcserver published dlls into client (everything built with same framework and same environment), and still some errors.

YES THIS HAS TO DUE WITH neo-cli. and it will be fixed in a minute. Add this to neo-cli not neo.dll

[cschuchardt88]

btw if test are broken then github action test should be more thorough

[vncoelho]

https://github.com/neo-project/neo-modules/pull/864/files

[cschuchardt88]

Has to do with the host not targeting right framework

[vncoelho]

The fact is that without neo-project/neo-modules@e9e7a07 the module does not build. But even with it is produces error when running, missing some dependencies. (it just occurs on nodes with RpcServer)
I forced added rpcserver published dlls into client (everything built with same framework and same environment), and still some errors.

YES THIS HAS TO DUE WITH neo-cli. and it will be fixed in a minute. Add this to neo-cli not neo.dll

Sure, if there is a good solution.

Just do not merge other PRs until we solve this.
I created another one on neo-modules in case this one is merged.
If not, let's just close it.

[vncoelho]

Has to do with the host not targeting right framework

In the case I have here, as we discussed recently, we are targeting net7.0.
Building everything (neo-cli and modules) and publishing with FROM mcr.microsoft.com/dotnet/sdk:7.0.404-jammy

Running with FROM mcr.microsoft.com/dotnet/aspnet:7.0.14-jammy

[vncoelho]

I can try with another commands. The setup here is simple to modify, everything is one line command and dockerized.

[cschuchardt88]

as in host I mean the one running the process. In this case its neo-cli . Is it the same for you?

[cschuchardt88]

see #3067, close this.

[cschuchardt88]

Plus don't forget 12-hour waiting period before merge....

[vncoelho]

Plus don't forget 12-hour waiting period before merge....

Plus, don't forget to push PRs that do not break everything...aehuahuea

[vncoelho]

The other PR fixed, @shargon

[shargon]

@vncoelho this works with neo-node and neo-gui, and future clients, because plugins are used by neo, but you choose @vncoelho

[shargon]

Has to do with the host not targeting right framework

The plugin is installed by the host, but is used by the framework, In my opinion, until we solve the dependency problem, we should revert it and find the good solution (not move the problem to another place)

[cschuchardt88]

why not update the exe projects. It's only 3 lines of code.

[cschuchardt88]

I don't understand why we are moving backward here. You have no good reasons. It's not like an release is around the corner.
You want things in sequences and PR #3067 does just that.

[shargon]

You have no good reasons.

The other PR is not a fix, it moves the problem, the real problem is load the dependencies from the plugin folder, this only moves the problem to another place

[cschuchardt88]

You want things in sequences and PR #3067 does just that.

Plus we dont build GUI anymore for release. Since 3.6.0 No GUI In Release

[vncoelho]

@shargon ,I really appreciate your attention.
But I am not expert in these libraries and frameworks to decide.

In fact,maybe revert is good decision.
As I understood, neo-cli needs its dll during execution. And plugins need aspnet framework for compilation.

What is not clear to me is the image @cschuchardt88 is mentioning.

[Jim8y]

Wait a sec, if this is reverted, isn't it mean we still using core instead of standard? @cschuchardt88

[shargon]

Wait a sec, if this is reverted, isn't it mean we still using core instead of standard? @cschuchardt88

We are trying to find the good solution

[vncoelho]

@shargon, too much instability on that other change. I am still not feeling safe to go.

The changes are requesting too much for the basic environment to build and run a simple client.

[cschuchardt88]

Its RestServer plugin its autoloading stuff it shouldnt

[cschuchardt88]

AFTER TESTING EVERYTHING THERE IS NO PROBLEMS!!! IT'S JUST USER ERROR!!!

[cschuchardt88]

@vncoelho

[shargon]

We will fix exes or modules instead of neo

[cschuchardt88]

@shargon we need it in both