Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix isDefault #2451

Merged
merged 5 commits into from
May 1, 2021
Merged

Fix isDefault #2451

merged 5 commits into from
May 1, 2021

Conversation

erikzhang
Copy link
Member

Fix #2450

@shargon
Copy link
Member

shargon commented Apr 27, 2021

Is not better to change the nep because all the json properties are in lowercase?

@erikzhang
Copy link
Member Author

isDefault is never used. It is not worth modifying the NEP.

shargon
shargon previously approved these changes Apr 27, 2021
View reviewed changes
@roman-khimov
Copy link
Contributor

I can't say we're using it often, but we do have a test for it and there is some associated logic.

https://github.com/nspcc-dev/neo-go/blob/933743ce870915ed8b15073f5bae0c4bdc710157/pkg/wallet/testdata/wallet2.json#L61

@shargon
Copy link
Member

shargon commented Apr 28, 2021

I will add a UT

shargon
shargon previously approved these changes Apr 28, 2021
View reviewed changes
vncoelho
vncoelho reviewed Apr 29, 2021
View reviewed changes
Copy link
Member

@vncoelho vncoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think this can be removed for now and changed to other name.

@erikzhang erikzhang mentioned this pull request Apr 30, 2021
Merged
@erikzhang erikzhang merged commit 8b94f22 into master May 1, 2021
@erikzhang erikzhang deleted the isDefault branch May 1, 2021 10:36
@fyrchik fyrchik mentioned this pull request May 14, 2021
Merged
@erikzhang erikzhang mentioned this pull request May 19, 2021
Open
@ixje ixje mentioned this pull request May 19, 2021
Merged
snowypowers pushed a commit to CityOfZion/neon-js that referenced this pull request May 19, 2021
@ixje
fix(wallet): Rename account.isdefault to isDefault (#738)
bc9947b 
The property was initially renamed to isdefault by neo-project/neo#1736 now renamed back to isDefault by neo-project/neo#2451.

Close #736
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon left review comments

@vncoelho vncoelho vncoelho left review comments

@roman-khimov roman-khimov roman-khimov left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NEP-6 inconsistency
4 participants
@erikzhang @shargon @roman-khimov @vncoelho