Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename native contracts #2152

Merged
merged 9 commits into from
Dec 17, 2020
Merged

Rename native contracts #2152

merged 9 commits into from
Dec 17, 2020

Conversation

erikzhang
Copy link
Member

@erikzhang erikzhang commented Dec 16, 2020 •
edited
Loading

  1. Rename ManagementContract to ContractManagement.
  2. Rename DesignationContract to RoleManagement.

@Tommo-L
Copy link
Contributor

Tommo-L commented Dec 16, 2020

BTW, rename Committee to Council

@erikzhang
Copy link
Member Author

BTW, rename Committee to Council

It's another pr.

@devhawk
Copy link
Contributor

devhawk commented Dec 16, 2020

Should We also change NeoToken/GasToken back to NEO and GAS?

@cloud8little
Copy link
Contributor

Should We also change NeoToken/GasToken back to NEO and GAS?

Agree

@erikzhang
Copy link
Member Author

Should We also change NeoToken/GasToken back to NEO and GAS?

I don't think so. NEO is ambiguous, does it mean token or blockchain? And it has the same name as the root namespace, which will cause many conflicts.

@Qiao-Jin Qiao-Jin mentioned this pull request Dec 16, 2020
Closed
@superboyiii
Copy link
Member

Do you think it's need to be merged into Preview4? @erikzhang

@Tommo-L
Copy link
Contributor

Tommo-L commented Dec 16, 2020

UT failed.

@fyrchik fyrchik mentioned this pull request Dec 16, 2020
Merged
vncoelho
vncoelho reviewed Dec 16, 2020
View reviewed changes
src/neo/SmartContract/Native/RoleDesignation.cs Outdated
@@ -14,12 +12,12 @@

namespace Neo.SmartContract.Native
{
public sealed class DesignationContract : NativeContract
public sealed class RoleDesignation : NativeContract
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe keep with ContractRoleDesignation to follow ContractManagement

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it is RoleManagement.

shargon
shargon previously approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@shargon shargon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me, but I prefer to merge this after preview4

@devhawk
Copy link
Contributor

devhawk commented Dec 16, 2020

It's ok for me, but I prefer to merge this after preview4

I agree 100%

@erikzhang
Copy link
Member Author

Now it can be merged.

@shargon shargon merged commit 13c626c into master Dec 17, 2020
@shargon shargon deleted the rename-native-contracts branch December 17, 2020 20:48
@shargon shargon mentioned this pull request Dec 17, 2020
Merged
ShawnYun pushed a commit to ShawnYun/neo that referenced this pull request Jan 8, 2021
@erikzhang @shargon
Rename native contracts (neo-project#2152)
2d88a6c 
* Rename native contracts

* Fix

* RoleManagement

Co-authored-by: Shargon <shargon@gmail.com>
cloud8little pushed a commit to cloud8little/neo that referenced this pull request Jan 24, 2021
@erikzhang @shargon @cloud8little
Rename native contracts (neo-project#2152)
3f666e2 
* Rename native contracts

* Fix

* RoleManagement

Co-authored-by: Shargon <shargon@gmail.com>
ixje added a commit to CityOfZion/neo-mamba that referenced this pull request Feb 3, 2021
@ixje
https://github.com/neo-project/neo/pull/2152
ff129b3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vncoelho vncoelho vncoelho left review comments

@shargon shargon shargon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@erikzhang @Tommo-L @devhawk @cloud8little @superboyiii @shargon @vncoelho