Add oracle Request/Response event #2036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shargon
reviewed
Oct 29, 2020
added 3 commits
October 29, 2020 18:24
|
I think you can get the responses from transactions. No notification is needed. https://github.com/neo-project/neo/blob/master/src/neo/Network/P2P/Payloads/OracleResponse.cs |
|
I think notification will be easy for users to record it, just extend the ApplicationLog plugin, since we have unified transaction types. |
After |
erikzhang
reviewed
Nov 3, 2020
Co-authored-by: Erik Zhang <erik@neo.org>
Co-authored-by: Erik Zhang <erik@neo.org>
shargon
reviewed
Nov 4, 2020
| @@ -161,6 +208,8 @@ private void Request(ApplicationEngine engine, string url, string filter, string | |||
| if (list.Count >= 256) | |||
| throw new InvalidOperationException("There are too many pending responses for this url"); | |||
| list.Add(id); | |||
|
|
|||
| engine.SendNotification(Hash, "Request", new VM.Types.Array { id, url, filter }); | |||
There was a problem hiding this comment.
Maybe this event's can be done by the project.
erikzhang
reviewed
Nov 5, 2020
added 2 commits
November 5, 2020 15:07
erikzhang
requested changes
Nov 5, 2020
Co-authored-by: Erik Zhang <erik@neo.org>
erikzhang
approved these changes
Nov 5, 2020
shargon
approved these changes
Nov 5, 2020
roman-khimov
added a commit
to nspcc-dev/neo-go
that referenced
this pull request
Nov 6, 2020
45 tasks
17 tasks
ShawnYun
pushed a commit
to ShawnYun/neo
that referenced
this pull request
Jan 8, 2021
* add event * add Request event * move Reponse into Finish method * format * optimize * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * fix * apply erik's feedback * add RequestContract * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Tommo-L <luchuan@neo.org> Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Shargon <shargon@gmail.com>
cloud8little
pushed a commit
to cloud8little/neo
that referenced
this pull request
Jan 24, 2021
* add event * add Request event * move Reponse into Finish method * format * optimize * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> * fix * apply erik's feedback * add RequestContract * Update src/neo/SmartContract/Native/Oracle/OracleContract.cs Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Tommo-L <luchuan@neo.org> Co-authored-by: Erik Zhang <erik@neo.org> Co-authored-by: Shargon <shargon@gmail.com>
ixje
added a commit
to CityOfZion/neo-mamba
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User need some way to query the oracle response tx.