-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable converting between public keys, script hashes and address #1428
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
36c1d16
Merge pull request #1 from neo-project/master
Qiao-Jin a1af198
Merge pull request #3 from neo-project/master
Qiao-Jin 3b8b3fe
Merge pull request #6 from neo-project/master
Qiao-Jin e9cf99b
Enable converting between public keys, script hashes and address
2e5dbda
Add test cases
c42daf5
Merge branch 'master' into master
shargon 914f831
Merge branch 'master' into master
Qiao-Jin 7af4612
Code optimization
a5d6d89
Fee adjusting
f747e5a
Code optimization
111b5c7
Merge pull request #8 from neo-project/master
Qiao-Jin b7c04c5
Add comment
3afeb33
Merge branch 'master' into master
Qiao-Jin 5117513
Merge branch 'master' into master
Qiao-Jin e7df5b1
Code optimization
4bf1d92
Merge pull request #9 from neo-project/master
Qiao-Jin b100d39
Code optimization
c7a332b
Merge from master
f452a68
Merge branch 'master' into master
Qiao-Jin 9cbcfdc
Update InteropService.Contract.cs
erikzhang 1962b94
Merge pull request #11 from neo-project/master
Qiao-Jin 93fe8a7
Code optimization
e9f2214
Merge branch 'master' into master
shargon 5efda66
Add wrong public key test cases
fa70610
Kick off new test
0e2a04b
format changing
bc2678c
Merge pull request #14 from neo-project/master
Qiao-Jin d306fb7
Merge branch 'master' into master
shargon 57d1aeb
Merge pull request #21 from neo-project/master
Qiao-Jin 5bb6d4e
Merge pull request #27 from neo-project/master
Qiao-Jin 308b0f0
Merge branch 'master' into master
Qiao-Jin 929aa41
Merge branch 'master' into master
shargon 0a37b33
Code optimization
1913033
Merge branch 'master' into master
Qiao-Jin 4a1c746
Merge branch 'master' into master
Qiao-Jin 09b2852
Add comment
8700661
Merge branch 'master' into master
Qiao-Jin 3075410
Merge branch 'master' into master
Qiao-Jin 8eb00a7
Merge branch 'master' into master
Qiao-Jin c8fb1be
Merge branch 'master' into master
Qiao-Jin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We decode the point for encode it later. Maybe in the future we should optimize this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This ensures the correctness of the public key format.
But it brought me to the question, will this SYSCALL cause non-deterministic problems? Maybe some implementations will directly encode the incorrectly formatted public key, resulting in inconsistent results of contract execution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should ensure this with unit tests. And ensure that all implementations pass the same unit tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Qiao-Jin could you add a comment for this possible issue in order to warn other implementations ? we must check first that the public key it's valid, before creating the script.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added the comment.