Moving rpc to plugin

src/neo/IO/Json/JArray.cs

@@ -151,5 +151,14 @@ public override string ToString()
             }
             return sb.ToString();
         }
+
+        public override object ToPrimitive()
+        {
+            ArrayList list = new ArrayList();
+
+            items.ForEach(o => list.Add(o.ToPrimitive()));
+
+            return list.ToArray();
+        }
     }
 }

src/neo/IO/Json/JBoolean.cs

@@ -60,5 +60,10 @@ public override string ToString()
         {
             return AsString();
         }
+
+        public override object ToPrimitive()
+        {
+            return AsBoolean();
+        }
     }
 }

src/neo/IO/Json/JNumber.cs

@@ -116,5 +116,10 @@ public override T TryGetEnum<T>(T defaultValue = default, bool ignoreCase = fals
             object result = Enum.ToObject(enumType, value);
             return Enum.IsDefined(enumType, result) ? (T)result : defaultValue;
         }
+
+        public override object ToPrimitive()
+        {
+            return AsNumber();
+        }
     }
 }

src/neo/IO/Json/JObject.cs

@@ -1,8 +1,9 @@
-using Neo.IO.Caching;
 using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Text;
+using Akka.Util.Internal;
+using Neo.IO.Caching;
 
 namespace Neo.IO.Json
 {
@@ -193,5 +194,72 @@ public static implicit operator JObject(string value)
         {
             return value == null ? null : new JString(value);
         }
+
+        public virtual object ToPrimitive()
+        {
+            Dictionary<string, object> dict = new Dictionary<string, object>();
+
+            Properties.ForEach(pair => dict.Add(pair.Key, pair.Value.ToPrimitive()));
+
+            return dict;
+        }
+
+        public static JObject FromPrimitive(object primitive)
+        {
+            if (primitive is JObject it)
+            {
+                return it;
+            }
+
+            if (primitive is Dictionary<string, object> dict)
+            {
+                var jobj = new JObject();
+                dict.ForEach(pair =>
+                {
+                    jobj.Properties.Add(pair.Key, FromPrimitive(pair.Value));
+                });
+
+                return jobj;
+            }
+
+            if (primitive is object[] arr)
+            {
+                var jobj = new List<JObject>();
+                arr.ForEach(item => jobj.Add(FromPrimitive(item)));
+                return new JArray(jobj.ToArray());
+            }
+
+            if (primitive is bool boolean)
+            {
+                return new JBoolean(boolean);
+            }
+
+            if (primitive is string str)
+            {
+                return new JString(str);
+            }
+
+            if (IsNumber(primitive))
+            {
+                return new JNumber(Convert.ToDouble(primitive));
+            }
+
+            return null;
+        }
+
+        private static bool IsNumber(object value)
+        {
+            return value is sbyte
+                   || value is byte
+                   || value is short
+                   || value is ushort
+                   || value is int
+                   || value is uint
+                   || value is long
+                   || value is ulong
+                   || value is float
+                   || value is double
+                   || value is decimal;
+        }
     }
 }

src/neo/IO/Json/JString.cs

@@ -86,5 +86,10 @@ public override T TryGetEnum<T>(T defaultValue = default, bool ignoreCase = fals
                 return defaultValue;
             }
         }
+
+        public override object ToPrimitive()
+        {
+            return AsString();
+        }
     }
 }

src/neo/NeoSystem.cs

@@ -25,7 +25,6 @@ public class NeoSystem : IDisposable
         public IActorRef LocalNode { get; }
         internal IActorRef TaskManager { get; }
         public IActorRef Consensus { get; private set; }
-        public RpcServer RpcServer { get; private set; }
 
         private readonly IStore store;
         private ChannelsConfig start_message = null;
@@ -45,7 +44,6 @@ public void Dispose()
         {
             foreach (var p in Plugin.Plugins)
                 p.Dispose();
-            RpcServer?.Dispose();
             EnsureStoped(LocalNode);
             // Dispose will call ActorSystem.Terminate()
             ActorSystem.Dispose();
@@ -88,13 +86,6 @@ public void StartNode(ChannelsConfig config)
             }
         }
 
-        public void StartRpc(IPAddress bindAddress, int port, Wallet wallet = null, string sslCert = null, string password = null,
-            string[] trustedAuthorities = null, long maxGasInvoke = default)
-        {
-            RpcServer = new RpcServer(this, wallet, maxGasInvoke);
-            RpcServer.Start(bindAddress, port, sslCert, password, trustedAuthorities);
-        }
-
         internal void SuspendNodeStartup()
         {
             suspend = true;

src/neo/Network/HttpException.cs

@@ -0,0 +1,12 @@
+using System;
+
+namespace Neo.Network
+{
+    public class HttpException : Exception
+    {
+        public HttpException(int code, string message) : base(message)
+        {
+            HResult = code;
+        }
+    }
+}

src/neo/Network/RPC/RpcClient.cs

@@ -45,7 +45,7 @@ public async Task<RpcResponse> SendAsync(RpcRequest request)
 
                 if (response.Error != null)
                 {
-                    throw new RpcException(response.Error.Code, response.Error.Message);
+                    throw new HttpException(response.Error.Code, response.Error.Message);
                 }
 
                 return response;