Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail on error Log #714

Closed
steven1227 opened this issue Apr 29, 2019 · 10 comments
Closed

Add more detail on error Log #714

steven1227 opened this issue Apr 29, 2019 · 10 comments
Labels
Discussion Initial issue state - proposed but not yet accepted Suggestion Ideas and suggestions that could be used for improving clarity, organization or even performance.

Comments

@steven1227
Copy link
Member

Currently, the error log throw by the RPC node is not that detail. It only contains little information such as block invalidation. For the smart contract invocation error, this problem becomes more serious as smart contract/Dapp may need to know what is the exact error.

Is it possible to add a more detailed log into the system when calling the RPC method and in the response body when invoking smart contract?

@vncoelho
Copy link
Member

Hi @steven1227, there is an limit in which we can provide information, because we try to make the Verification process as quick as possible.

I believe that we could improve the Policy Filter logs, providing more details about why it was denied (in terms of fees and size).

@steven1227
Copy link
Member Author

@vncoelho
Thanks. That would be great. Is it possible to add more customized log in the result stack when the error happened in smart contract invocation?

@vncoelho
Copy link
Member

vncoelho commented Apr 29, 2019

@steven1227, I believe that the best way would be to manually insert more notifications. But @igormcoelho and @shargon might give us more ideas.
I think that a specialized plugin could give you such informations. In this sense, we could have some nodes that are dedicated for that!

@vncoelho
Copy link
Member

For the future, I believe that the Ecosystem will have other types of specialized nodes, which is, in our vision, the core of Multi-Agent Systems.

In this sense, different entities that use the NEO blockchain might provide such services.
I think that it is plausible to have such real-time debugging, @steven1227.
In particular, we are now writing NEO code on c++ (https://github.com/NeoResearch/neopt), which will be probably quite portable for frontends and this kind of analyses. But that will still take some time.

@steven1227
Copy link
Member Author

steven1227 commented Apr 29, 2019

@vncoelho Yes. Maybe a plugin can be a good solution. Then smart contract developer can get the info by using this plugin with his own nodes.

@erikzhang erikzhang added the Discussion Initial issue state - proposed but not yet accepted label Apr 29, 2019
@shargon
Copy link
Member

shargon commented May 21, 2019

I think that this is very important, a lot of time was wasted in known why a transaction fail, is the gas? is the signature? is the format?

we need to know the reason in some errors, is not enough with the false return

something like:

public bool IsValid(out string error) {} 

@vncoelho vncoelho added this to the NEO 3.0 milestone Jun 11, 2019
@vncoelho vncoelho added the Suggestion Ideas and suggestions that could be used for improving clarity, organization or even performance. label Jun 11, 2019
@longfeiWan9
Copy link
Member

I think that this is very important, a lot of time was wasted in known why a transaction fail, is the gas? is the signature? is the format?

we need to know the reason in some errors, is not enough with the false return

something like:

public bool IsValid(out string error) {} 

Totally agree, detailed error message is so important for dApp or any NEO related development. Currently, projects are constantly asking why their tx is failed.

@lock9
Copy link
Contributor

lock9 commented Jul 23, 2019

@neo-project/core can I move this to the plugins repository? What do you guys think?
I think it is very important to know the reason that a transaction failed, but I don't see this as a "core" feature. What is your opinion?

@erikzhang erikzhang removed this from the NEO 3.0 milestone Jul 24, 2019
@shargon
Copy link
Member

shargon commented Jul 24, 2019

I think that should be here, we need more verbosity in too many sites, like TX verification

@lock9
Copy link
Contributor

lock9 commented Aug 4, 2019

@steven1227 and @neo-project/core I will close this in favor of this plugin.
If you guys think this is a mistake, please reopen this issue.
Thanks

@lock9 lock9 closed this as completed Aug 4, 2019
Thacryba pushed a commit to simplitech/neo that referenced this issue Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Discussion Initial issue state - proposed but not yet accepted Suggestion Ideas and suggestions that could be used for improving clarity, organization or even performance.
Projects
None yet
Development

No branches or pull requests

6 participants