Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use commands that need to open wallet via JSON-RPC #305

Closed
chenzhitong opened this issue Jul 9, 2018 · 3 comments
Closed

Can't use commands that need to open wallet via JSON-RPC #305

chenzhitong opened this issue Jul 9, 2018 · 3 comments
Labels
Bug Used to tag confirmed bugs

Comments

@chenzhitong
Copy link
Member

chenzhitong commented Jul 9, 2018

Can't use commands that need to open wallet via JSON-RPC, like getbalancedumpprivkey.
I guess because there is no value given to "wallet" in the following code.

public RpcServer(NeoSystem system, Wallet wallet = null)
{
this.system = system;
this.wallet = wallet;
}

neo/neo/NeoSystem.cs

Lines 57 to 61 in 18be40a

public void StartRpc(int port, string sslCert = null, string password = null)
{
rpcServer = new RpcServer(this);
rpcServer.Start(port, sslCert, password);
}

@chenzhitong chenzhitong changed the title Can‘t access wallet via json rpc Can't use commands that need to open wallet via JSON-RPC Jul 9, 2018
@erikzhang erikzhang added the Bug Used to tag confirmed bugs label Jul 9, 2018
@erikzhang erikzhang added this to the NEO 3.0 milestone Jul 9, 2018
@f27d
Copy link

f27d commented Jul 9, 2018

@daiduongtruong
Copy link

daiduongtruong commented Jul 9, 2018 via email

erikzhang pushed a commit that referenced this issue Jul 27, 2018
@wy
Copy link
Contributor

wy commented Aug 27, 2018

Can this be closed now @erikzhang with your fix?

erikzhang added a commit that referenced this issue Sep 14, 2018
* refactoring

* message priority

* add failure reason for `sendrawtransaction` (neo-project/neo-node#116)

* fix bug in `sendrawtransaction`

* improve RpcServer and Plugin system

* add `unconnected` to RPC command `getpeers`

* update dependencies:

- Microsoft.AspNetCore.ResponseCompression v2.1.1
- Microsoft.AspNetCore.Server.Kestrel v2.1.1
- Microsoft.AspNetCore.Server.Kestrel.Https v2.1.1
- Microsoft.EntityFrameworkCore.Sqlite v2.1.1
- Microsoft.Extensions.Configuration.Json v2.1.1

* add WebSocket

* fix bug in Snapshot.Dispose()

* Hides the caught exceptions logs in `RemoteNode`

* fix block stuck

* fix bug in p2p connection

* fix #305

* fix consensus

* checked on Fixed8 mul

* solve the problem of disconnecting from peers

* fix bug in `System.Runtime.GetTime`

* add RPC command: `getwalletheight`

* fix p2p bug

* Prevent error messages when exiting

* optimize p2p network

* allow user interface to send messages to plugins

* change version to 2.9.0

* backward compatible for sendrawtransaction

* Solve the problem of resynchronizing blocks

* put unverified transactions in the memory pool back into the message queue after the block is persisted

* minor change to consensus
@erikzhang erikzhang removed this from the NEO 3.0 milestone Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Used to tag confirmed bugs
Projects
None yet
Development

No branches or pull requests

5 participants