Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

dotnet 5.0 #681

Merged
merged 32 commits into from
Dec 22, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
68270b2
打开钱包当文件不存在时错误提示更友好
Aug 22, 2017
6951b0d
Merge pull request #1 from neo-project/master
Nov 16, 2017
dda60bd
Show wallet height when executing "show state" command. Keep in line …
chenzhitong Nov 16, 2017
91f0c38
fixed bug
chenzhitong Nov 16, 2017
cad3b90
修复Bug
chenzhitong Nov 21, 2017
6e91717
optimize
Nov 21, 2017
7e00066
fix
Nov 21, 2017
29019a7
Merge pull request #2 from neo-project/master
Jun 4, 2018
f68e648
Merge pull request #4 from neo-project/master
Dec 13, 2018
707070b
Merge pull request #5 from neo-project/master
Jun 12, 2020
859440f
Merge pull request #6 from neo-project/master
Sep 11, 2020
9bf1e26
Merge pull request #7 from neo-project/master
Oct 13, 2020
b83c822
Merge pull request #8 from neo-project/master
Nov 18, 2020
173c785
Upgrade target framework.
Nov 23, 2020
a18d2bf
Merge branch 'master' into net5
Nov 23, 2020
0e6e10c
update
Nov 23, 2020
f1d9ca0
Update dotnetcore.yml
Nov 23, 2020
d038177
Update dotnetcore.yml
Nov 23, 2020
42d0ef7
Update SignerWrapper.cs
Nov 23, 2020
cd4c951
Revert "Update SignerWrapper.cs"
Nov 23, 2020
cece0a5
Update dotnetcore.yml
Nov 23, 2020
7c4b6ab
use shared directory.build.props file
Nov 23, 2020
9d3c98c
Update Dockerfile
Nov 25, 2020
706be13
Update Dockerfile
Nov 25, 2020
63194a4
Update Directory.Build.props
shargon Dec 21, 2020
8ca320a
Merge branch 'master' into net5
shargon Dec 21, 2020
2b87040
Update neo-gui.csproj
erikzhang Dec 22, 2020
7f5df4e
Update .github/workflows/dotnetcore.yml
erikzhang Dec 22, 2020
985b362
format
erikzhang Dec 22, 2020
2bb1a42
Remove Directory.Build.props
erikzhang Dec 22, 2020
58218bb
format
erikzhang Dec 22, 2020
0169fa2
Update dependencies
erikzhang Dec 22, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .editorconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Core EditorConfig Options #
###############################

# dotnet-format requires version 3.1.37601
# dotnet-format requires version 5.0.100
# dotnet tool update -g dotnet-format
# remember to have: git config --global core.autocrlf false #(which is usually default)

Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/dotnetcore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: .NET Core Test
on: pull_request

env:
DOTNET_VERSION: 3.0.100
DOTNET_VERSION: 5.0.100

jobs:

Expand All @@ -22,8 +22,8 @@ jobs:
- name: Check format
if: runner.os == 'Linux'
run: |
dotnet tool install --version 3.2.111002 --tool-path ./ dotnet-format --add-source https://dotnet.myget.org/F/format/api/v3/index.json
./dotnet-format --check --dry-run -v diagnostic
dotnet tool install --version 5.0.142902 --tool-path ./ dotnet-format --add-source https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-tools/nuget/v3/index.json
./dotnet-format --check -v diagnostic
- name: Build CLI
if: runner.os == 'Linux'
run: |
Expand Down
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/dotnet/core/sdk:3.0 AS Build
FROM mcr.microsoft.com/dotnet/sdk:5.0.0 AS Build

COPY neo-cli /neo-cli
COPY Neo.ConsoleService /Neo.ConsoleService
Expand All @@ -7,7 +7,7 @@ COPY NuGet.Config /neo-cli
WORKDIR /neo-cli
RUN dotnet restore && dotnet publish -c Release -o /app

FROM mcr.microsoft.com/dotnet/core/runtime:3.0 AS Final
FROM mcr.microsoft.com/dotnet/runtime:5.0.0 AS Final
RUN apt-get update && apt-get install -y \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.0.100 as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, they updated the namespaces for their docker images. See dotnet/dotnet-docker#2375

The new one should be mcr.microsoft.com/dotnet/runtime:5.0 (or whatever version you want)

screen \
libleveldb-dev \
Expand Down
1 change: 1 addition & 0 deletions Neo.ConsoleService/ConsoleServiceBase.cs
Original file line number Diff line number Diff line change
Expand Up @@ -558,6 +558,7 @@ public void Run(string[] args)
}
else
{
Debug.Assert(OperatingSystem.IsWindows());
ServiceBase.Run(new ServiceProxy(this));
}
}
Expand Down
6 changes: 3 additions & 3 deletions Neo.ConsoleService/Neo.ConsoleService.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@

<PropertyGroup>
<Copyright>2015-2020 The Neo Project</Copyright>
<Version>1.0.0</Version>
<Version>1.1.0</Version>
<Authors>The Neo Project</Authors>
<TargetFramework>netstandard2.1</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
<PackageProjectUrl>https://github.com/neo-project/neo-node</PackageProjectUrl>
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<RepositoryType>git</RepositoryType>
Expand All @@ -13,7 +13,7 @@

<ItemGroup>
<PackageReference Include="System.Runtime.Loader" Version="4.3.0" />
<PackageReference Include="System.ServiceProcess.ServiceController" Version="4.7.0" />
<PackageReference Include="System.ServiceProcess.ServiceController" Version="5.0.0" />
</ItemGroup>

</Project>
2 changes: 1 addition & 1 deletion neo-cli/neo-cli.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<AssemblyTitle>Neo.CLI</AssemblyTitle>
<Version>3.0.0-preview4</Version>
<Authors>The Neo Project</Authors>
<TargetFramework>netcoreapp3.0</TargetFramework>
<TargetFramework>net5.0</TargetFramework>
<AssemblyName>neo-cli</AssemblyName>
<OutputType>Exe</OutputType>
<PackageId>Neo.CLI</PackageId>
Expand Down
54 changes: 27 additions & 27 deletions neo-gui/GUI/Wrappers/SignerWrapper.cs
Original file line number Diff line number Diff line change
@@ -1,27 +1,27 @@
using Neo.Cryptography.ECC;
using Neo.Network.P2P.Payloads;
using System.Collections.Generic;
using System.ComponentModel;
namespace Neo.GUI.Wrappers
{
internal class SignerWrapper
{
[TypeConverter(typeof(UIntBaseConverter))]
public UInt160 Account { get; set; }
public WitnessScope Scopes { get; set; }
public List<UInt160> AllowedContracts { get; set; } = new List<UInt160>();
public List<ECPoint> AllowedGroups { get; set; } = new List<ECPoint>();
public Signer Unwrap()
{
return new Signer
{
Account = Account,
Scopes = Scopes,
AllowedContracts = AllowedContracts.ToArray(),
AllowedGroups = AllowedGroups.ToArray()
};
}
}
}
using Neo.Cryptography.ECC;
using Neo.Network.P2P.Payloads;
using System.Collections.Generic;
using System.ComponentModel;

namespace Neo.GUI.Wrappers
{
internal class SignerWrapper
{
[TypeConverter(typeof(UIntBaseConverter))]
public UInt160 Account { get; set; }
public WitnessScope Scopes { get; set; }
public List<UInt160> AllowedContracts { get; set; } = new List<UInt160>();
public List<ECPoint> AllowedGroups { get; set; } = new List<ECPoint>();

public Signer Unwrap()
{
return new Signer
{
Account = Account,
Scopes = Scopes,
AllowedContracts = AllowedContracts.ToArray(),
AllowedGroups = AllowedGroups.ToArray()
};
}
}
}
4 changes: 2 additions & 2 deletions neo-gui/neo-gui.csproj
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
<Project Sdk="Microsoft.NET.Sdk.WindowsDesktop">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Copyright>2016-2020 The Neo Project</Copyright>
<AssemblyTitle>Neo.GUI</AssemblyTitle>
<Version>3.0.0-preview4</Version>
<Authors>The Neo Project</Authors>
<OutputType>WinExe</OutputType>
<TargetFramework>netcoreapp3.0</TargetFramework>
<TargetFramework>net5.0-windows</TargetFramework>
<RootNamespace>Neo</RootNamespace>
<UseWindowsForms>true</UseWindowsForms>
<Company>The Neo Project</Company>
Expand Down
36 changes: 18 additions & 18 deletions tests/Neo.ConsoleService.Tests/Neo.ConsoleService.Tests.csproj
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netcoreapp3.0</TargetFramework>
<RootNamespace>neo_cli.Tests</RootNamespace>
</PropertyGroup>
<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.5.0" />
<PackageReference Include="MSTest.TestAdapter" Version="2.1.0" />
<PackageReference Include="MSTest.TestFramework" Version="2.1.0" />
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\..\Neo.ConsoleService\Neo.ConsoleService.csproj" />
</ItemGroup>
</Project>
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<TargetFramework>net5.0</TargetFramework>
<RootNamespace>neo_cli.Tests</RootNamespace>
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.8.3" />
<PackageReference Include="MSTest.TestAdapter" Version="2.1.2" />
<PackageReference Include="MSTest.TestFramework" Version="2.1.2" />
</ItemGroup>

<ItemGroup>
<ProjectReference Include="..\..\Neo.ConsoleService\Neo.ConsoleService.csproj" />
</ItemGroup>

</Project>